Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean variable should be made consistent in look and behaviour #2451

Open
Geoffree3 opened this issue Sep 27, 2019 · 4 comments
Open

Boolean variable should be made consistent in look and behaviour #2451

Geoffree3 opened this issue Sep 27, 2019 · 4 comments

Comments

@Geoffree3
Copy link

** Is your feature request related to a problem? Please describe.
The look of boolean variables are not consistent. For example condition fields are pointy ended boxes which fit the defined 'true' and 'false' constants. This can be confusing to the user. The current situation and a proposed solution is outlined below.

**The problem and a possible solution
When a variable is assigned to a boolean value, as in the 'on start' function, the editor clearly knows that it is a boolean. This is reflected (as illustrated below) in the errors given when trying to set it to a number or as a parameter in the 'show number' function. However, the user is not given this feedback. For example, the boolean variable (roundy ends) can be inserted as a condition in the 'if statement' despite the fact that a boolean value (and corresponding field) is shown as a pointy ended box (see next image).
boolean1

Pointy condition field.
boolean3

The solution is to make boolean variables the correct shape to fit the boolean field, as below
boolean3 revised

The make variable panel needs changing otherwise it is inconsistent (as below). If 'bouncing' is a boolean then obviously it cannot be set to a number or changed by 1.
boolean2

The revised (and consistent) variables panel would look like this.
boolean make variable

Boolean variable are now consistent in 'fitting' boolean fields and not fitting non-boolean fields. As shown below, the user can easily see that the boolean variable 'bouncing' can be used as a condition.
boolean in use

@abchatra
Copy link
Collaborator

All variables are circular today. This requires some type analysis on the variable to show the type. @riknoll

@Geoffree3
Copy link
Author

Geoffree3 commented Sep 29, 2019 via email

@abchatra
Copy link
Collaborator

Variable needs to change shape after they are created. As all the variables are created as number type first.

@Geoffree3
Copy link
Author

Geoffree3 commented Sep 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants