Update of Button and Pin input blocks #89

Amerlander · 2020-02-20T02:32:39Z

adds the event types usable for Button and Pin events
merges the onPinPressed & the onPinReleased blocks into a new onPinEvent block.
creates a new onButtonEvent block, which replaces the old onButtonPressed one (which actually was click-listener instead of pressed)
change the game.ts to use the new onButtonEvent function
the old blocks are left on the code side for compatibility

* handle continuous state * adding shims * update rendering for continuous servos * fixing sim * fix sig * typo * fix sim * bump pxt * bump pxt

- add Button and Pin event types - merge onPinPressed & onPinReleased in new onPinEvent function - create new onButtonEvent function

Amerlander · 2020-02-20T02:44:32Z

ok, I see. I have to change the tests first.

pelikhan · 2020-02-20T15:16:19Z

I recommend having an enum that hides DAL

Amerlander · 2020-02-20T16:57:03Z

thank you, used the enum now instead of DAL.

I also brought back the deprecated blocks, so they are displayed in block view when old hex files or js code is imported.

pelikhan · 2020-02-20T20:19:43Z

I would recommend to create a new extension for these blocks to simplify your life w.r.t. to merging Microbit changes. Also we are trying to keep all the editors compatible so this should probably go into common packages.

Amerlander · 2020-02-21T08:10:47Z

I'm not sure how this simplifies my life, since I'm still working myself into this and have to figure out how things work in pxt.

If I create an extension I would still want to disable the existing button- and pin-pressed-blocks, since I don't want to have four same same but different blocks. So all the docs and tutorials would still need to change in compare to Microbit.
common packages could be a way. The buttons.cpp also already has the button events as enum, but I don't know yet what to change there and after how to bind it into pxt-calliope. And still, if Microbit doesn't sneak in to this, it wouldn't be easier to merge their changes later at all?

My reason for these changes are, that the block on Button A pressed in fact listens to click and not down event. And instead oft just renaming or changing the event I thought iit would be nice to have a choice. And since I wasn't able to put the event as an optional parameter into the existing blocks I created new ones to replace the existing.

The Microbit pin and button event listeners have the same mix-up of pressed and click, so I think it would make sense to change it there too.
If it makes sense to put these changes in common packages, could you assist me with getting them in there? And when Microbit makes use of them we can just merge their changes into pxt-calliope which makes sure we're not going apart.

MKleinSB · 2020-02-25T10:33:21Z

I remembered this issue: microsoft/pxt-microbit#963
Doesn´t it affect your problem, too?

pelikhan · 2020-03-19T14:22:17Z

ready?

pelikhan · 2020-02-20T15:15:11Z

docs/examples/gameofLife.md

@@ -22,13 +22,13 @@ Here's a program that simulates cell life in the LED matrix. Use button ``A`` fo
 let lifeChart: Image = null

 //Use button A for the next iteration of game of life
-input.onButtonPressed(Button.A, () => {
+input.input.onButtonEvent(Button.A, DAL.MICROBIT_BUTTON_EVT_CLICK, () => {


Really? Kids should not have to deal with the DAL object. This is super ugly.

yes, this is outdated and changed within 07fe264

pelikhan · 2020-03-19T14:49:44Z

docs/examples/gameofLife.md

@@ -22,13 +22,13 @@ Here's a program that simulates cell life in the LED matrix. Use button ``A`` fo
 let lifeChart: Image = null

 //Use button A for the next iteration of game of life
-input.onButtonPressed(Button.A, () => {
+input.input.onButtonEvent(Button.A, ButtonEvent.Click, () => {


double input?

no, the other one is the outdated file, so this is what the kids will deal with.

They have to type Input twice?

ah, sorry. Yes, that's wrong. I`ll change that.

pelikhan · 2020-03-19T14:51:26Z

This change will make future merging from upstream microbit harder.

MKleinSB · 2020-03-19T15:33:20Z

@Amerlander I agree to pelikhan. Wait with the update of the pinevent. The standard Calliope user doesn´t see the difference. It it necessary to keep merging of microbit source easy. The Pinevents will be (perhaps) updated. Look, there is a new issue
microsoft/pxt-microbit#2667

Amerlander · 2020-03-19T15:52:54Z

@MKleinSB, of course it would make sense to wait when micro bit is changing there something at all. I just wonder whether there is any plan to do this and how I could help with that.

The Issue on the micro bit side was labeled with "next-release", but then removed. They said in 2018 they will introduce a fix next year, but since then there is not really any progress in the issue and also not an answer to my question. I would be glad if the issue can be closed on the side of micro bit, and we can just check in.

The issue microsoft/pxt-microbit#2667 doesn't seem to target this, since its more about when a click event is triggered and when it is a long click and when its not a click at all (a down event where another event comes in between before the up event is not triggered as click anymore). And there the behavior seems to differ from simulator to hardware.

MKleinSB · 2020-03-19T15:59:04Z

@Amerlander If you stay working on makecode.calliope it´s ok ( for me ;-) )

pelikhan · 2020-03-20T15:21:54Z

I would recommend to create a new extension that produces the better blocks then merging would be easier. We should setup a call to discuss these things.

Amerlander · 2020-03-22T11:58:59Z

@MKleinSB I'm pretty sure I'll stay, even when this isn't the only thing I'm working on.

@pelikhan having a call to discuss this sounds great.

Juri added 13 commits February 13, 2020 22:58

change simulator svg

f291bd9

change radio image

3e9c26d

Remove google fonts cdn

3131298

change color of 'advanced' button

c672fff

font fix

14d8667

font fix 2

7c0e408

display fix

3501875

Merge remote-tracking branch 'origin/master'

2ed28d7

change fullsceen simulator bg

90ca470

Continuous servo

34a651b

* handle continuous state * adding shims * update rendering for continuous servos * fixing sim * fix sig * typo * fix sim * bump pxt * bump pxt

rerun travis

3fa02a7

Merge remote-tracking branch 'origin/master'

9c8595a

Input blocks revision

38cf0ec

- add Button and Pin event types - merge onPinPressed & onPinReleased in new onPinEvent function - create new onButtonEvent function

Amerlander requested a review from pelikhan February 20, 2020 02:33

Amerlander added 2 commits February 20, 2020 04:01

update input blocks in docs and tests

c2cdcaa

remove device_pin_release block

004b1d9

Amerlander added 3 commits February 20, 2020 17:00

Hide DAL.x behind Enum

07fe264

bring back deprecated blocks, but hide them

b91ae2c

shims and locales files

0803a13

Amerlander mentioned this pull request Feb 25, 2020

on touched, on released, unexpected behaviour microsoft/pxt-microbit#963

Open

Merge remote-tracking branch 'MICROSOFT/master'

4c30ce5

pelikhan reviewed Mar 19, 2020

View reviewed changes

Amerlander added 2 commits March 19, 2020 16:26

fix input.input. typing

f30ff02

Merge branch 'master' of https://github.com/calliope-edu/pxt-calliope

1b7f2c3

Merge tag 'v2.1.55'

4b09f83

This was referenced May 5, 2020

Fetch changes from microbit #100

Closed

fetch pxt-microbit v2.2.30 #102

Merged

Merge branch 'master_ms'

1450feb

Amerlander closed this Aug 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of Button and Pin input blocks #89

Update of Button and Pin input blocks #89

Amerlander commented Feb 20, 2020

Amerlander commented Feb 20, 2020

pelikhan commented Feb 20, 2020

Amerlander commented Feb 20, 2020

pelikhan commented Feb 20, 2020

Amerlander commented Feb 21, 2020

MKleinSB commented Feb 25, 2020

pelikhan commented Mar 19, 2020

pelikhan Feb 20, 2020

Amerlander Mar 19, 2020

pelikhan Mar 19, 2020

Amerlander Mar 19, 2020

pelikhan Mar 19, 2020

Amerlander Mar 19, 2020

pelikhan commented Mar 19, 2020

MKleinSB commented Mar 19, 2020

Amerlander commented Mar 19, 2020

MKleinSB commented Mar 19, 2020

pelikhan commented Mar 20, 2020

Amerlander commented Mar 22, 2020

Update of Button and Pin input blocks #89

Update of Button and Pin input blocks #89

Conversation

Amerlander commented Feb 20, 2020

Amerlander commented Feb 20, 2020

pelikhan commented Feb 20, 2020

Amerlander commented Feb 20, 2020

pelikhan commented Feb 20, 2020

Amerlander commented Feb 21, 2020

MKleinSB commented Feb 25, 2020

pelikhan commented Mar 19, 2020

pelikhan Feb 20, 2020

Choose a reason for hiding this comment

Amerlander Mar 19, 2020

Choose a reason for hiding this comment

pelikhan Mar 19, 2020

Choose a reason for hiding this comment

Amerlander Mar 19, 2020

Choose a reason for hiding this comment

pelikhan Mar 19, 2020

Choose a reason for hiding this comment

Amerlander Mar 19, 2020

Choose a reason for hiding this comment

pelikhan commented Mar 19, 2020

MKleinSB commented Mar 19, 2020

Amerlander commented Mar 19, 2020

MKleinSB commented Mar 19, 2020

pelikhan commented Mar 20, 2020

Amerlander commented Mar 22, 2020