-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4 updates for beta testing #147
Conversation
* handle continuous state * adding shims * update rendering for continuous servos * fixing sim * fix sig * typo * fix sim * bump pxt * bump pxt
- add Button and Pin event types - merge onPinPressed & onPinReleased in new onPinEvent function - create new onButtonEvent function
@abchatra we updated or removed all extensions inside |
This is not just preferredRepos. We can't serve the extensions which doesn't have MIT license (This is more of a legal issue than technical). Even approvedRepos have to be MIT license. For example: https://github.com/calliope-edu/pxt-SCD30 doesn't have MIT license. Is there any issue in adding the MIT license for them? All these repos are severed text files any way so users can use them as library. |
We just didn't know that an MIT license is necessary. The license has been updated at all the extensions. |
@joernalraun we only updated the preffered repos, not all listed. The pxt-SCD30 has MIT, but its only mentioned inside the Readme, there is the License file missing. I'll go through the list and add the MIT license or remove them if they have other licenses. |
@abchatra I checked now every extension and removed it if there was no license file with MIT License included. Since The extension The following extensions have a MIT License mentioned in the Readme, but wthout the full license text and no license file. So they are the same like the https://github.com/calliope-edu/pxt-SCD30 you mentioned:
I removed all of them in the calliope target, but they are still present in the microbit target. |
Thanks @Amerlander We do have an issue to track down these extensions authors in microbit for the license. |
We will probably remove these extensions from microbit as well if the license is not updated. However we don't want to add additional dependencies for these now in calliope. Thanks for doing this and sorry for the inconvenience. |
Hi @abchatra is there anything else we could do now to help getting the process through? |
This is good to go. We are checking on the build failures and will merge after that. |
Weird, Github gave the commit a green checkmark even though the build failed. We need to investigate the yotta config for this repo... @Amerlander what is the state of https://github.com/calliope-mini/target-calliope-mini-classic-gcc? |
@riknoll If you have more questions we could also set up a video call now or the next days if you like. |
@Amerlander thanks! I think I've got a handle on things now, I'm planning on merging some changes to our backend later this afternoon to accommodate this. I'll let you know how it goes! Out of curiosity, is there a reason that version 1.2.3 isn't merged into master? |
@riknoll no, there isnt. I just merged it into master. |
@Amerlander cloud compile is updated! The C++ portion of the build is now succeeding on master. The build is still failing on documentation checks, though. Our CI runs through all of the TypeScript snippets in docs to make sure they compile as a check for breaking changes. |
You can disable docs checking by editing the pxtarget.json and adding If the snippets in the docs are not meant to compile, you can also ignore them on a case-by-case basis by changing the code snippet in the markdown file to use the "typescript-ignore" language. For example: ```typescript-ignore
// code here
``` |
So it might be possible to disable these checks for having a public available beta version and enable them back again later? The changes you just merged are a big improvement, but we still have a list of things that have to be changed for a final release. So our plan was to use this beta to get feedback from our community and improve it step by step from here until everything works as expected. |
I think that should be fine! @abchatra FYI |
@Amerlander the build is still a little broken, doesn't seem like it can update beta for some reason. I'm going to investigate, but in the meantime here is a build with the changes pushed: https://makecode.calliope.cc/app/f3b8cb87d8c932e5673206a3808d227e36964416-1e24dc8c20 |
@riknoll thank you, I think that might be enough for now. We will start creating issues on that basis and improve it step by step, that might also solve the broken build process. |
A static hosted version of these changes can be seen at betamc.calliope.cc