-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does this extension always activate? #228
Comments
Hey Tyler, @tehcrashxor @davidjenni can you please answer about why do we need 'onStartupFinished' event. |
Does this apply to all YAML & HTML files or is there a common file name for Power Portal files where the workspaceContains activation event would be more accurate? |
@TylerLeonhardt isn't the The one potentially expensive work is unzipping a .nupkg with our pac CLI; but that extra work only happens if a newer .vsix also contains a newer version of our .nupkg. In startups after that, it should be cheaper. Since you're on the vscode team, I'd be happy to have a conversation via corporate Teams, pls add @tehcrashxor, @ashishchoudhary001 (in IST timezon) and myself to that convo. |
can you tell me why this extension needs to be activated for:
onStartupFinished
onLanguage:yaml
onLanguage:html
From my perspective, this extension isn't going to be used all the time to warrant these events and an extension activating when it shouldn't need to ends up annoying customers and impacts performance.
The text was updated successfully, but these errors were encountered: