feat: support proxy in connect/connectOverCDP #35389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
feat-connect-proxy
branch
from
228e382 to
6f8aff5
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
suggested changes
Mar 28, 2025
| if (params.proxy) { | ||
| options.agent = createProxyAgent(params.proxy, new URL(params.url)); | ||
| } else { | ||
| const proxyURL = getProxyForUrl(params.url); |
There was a problem hiding this comment.
This is hard to follow imo. The first if-condition is 'if there is a user-specified proxy'. The second condition is 'getProxyForUrl' but in reality its 'getProxyFromEnvForUrl'. I think we can do something like this:
const proxyFromEnv = getProxyForUrl(params.url);
const proxyFromEnvObj = proxyFromEnv ? { server: proxyFromEnv } : undefined;
options.agent = createProxyAgent(params.proxy ?? proxyFromEnvObj, new URL(params.url));This in theory should allow us to get rid f the whole "else clause" This has one disadvantage tho after thinking about it. It would end up that we do CONNECT requests for all the http requests. It would mean we would have to move the options = either into createProxyAgent or add the HttpProxyAgent dependency which seems reasonable (one dependency from the same author of https-proxy-agent`). Maybe follow-up and get rid of the TODO in createProxyAgent?
There was a problem hiding this comment.
I am afraid to touch this willy-nilly because it is used for the npx playwright install. Therefore I made the smallest change possible by respecting the user-supplied proxy if any. We can try to follow up with some opt-out env variable, or leave with it for one more release.
mxschmitt
approved these changes
Mar 28, 2025
dgozman
force-pushed
the
feat-connect-proxy
branch
from
6f8aff5 to
256f5c3
Compare
Test results for "tests others"3 flaky21846 passed, 506 skipped Merge workflow run. |
Test results for "tests 1"1 failed 2 flaky38914 passed, 805 skipped Merge workflow run. |
Test results for "tests 2"2 fatal errors, not part of any test 107 flaky241352 passed, 9402 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Apr 8, 2025
This reverts commit 471a28e. Reason: decided to skip an explicit API and instead follow Node.js attempts to supports HTTP_PROXY and HTTPS_PROXY.
dgozman
added a commit
that referenced
this pull request
Apr 8, 2025
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Apr 10, 2025
Extracted from microsoft#35389. No behavior change whatsoever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35206, closes #33894.