-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Is there a way to ignore small difference between snapshots? #7346
Comments
I wonder if you would benefit from us hiding the cursor when capturing the screenshot instead. |
No, I think it's a partial soltion, that may even harm other people. |
@DZakh This is an interesting idea, but we have to gather more feedback before changing how snapshot matching works. Meanwhile, you can also capture an element screenshot to avoid the area with the ever-changing version, or anything else that is not stable. Would that work for you? |
This is also a feature that will help us, as we need to ignore some parts in our screenshoot that always are moving and making the comparison fails |
@DZakh as of 547a328 we now hide blinking cursor when making the screenshot. This is already available on
You understand correctly, and that's pretty unfortunate. We have another tracking bug for this: #10219
@sergioariveros this is coming via #11913 I'll close this in favor of mentioned separate issues. |
@aslushnikov It looks like the cursor is not hidden on firefox (Linux). I had to add |
@ritz078 interesting! Could you please share a repro? (Preferrably, in a new issue) |
I have an expected image snapshot and the only different thing comparing to an actual one is the text cursor. Because of this my test suit fails. I've tryed to increase the threshold option to the max but it didn't work. Do I understand it correctly, that threshold is only related to how accurate different pixels are found, not to the percentage of omitted overlapping pixels.
In my case the variable
count
from the source always returns 16 and threshold doesn't change anything.In my opinion it should work something like this:
Is there a way to ignore small difference between snapshots?
The text was updated successfully, but these errors were encountered: