Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] codegen inserts AltGraph key press #5854

Closed
black-silence opened this issue Mar 17, 2021 · 2 comments · Fixed by #6086
Closed

[BUG] codegen inserts AltGraph key press #5854

black-silence opened this issue Mar 17, 2021 · 2 comments · Fixed by #6086
Assignees

Comments

@black-silence
Copy link

Context:

  • Playwright Version: 1.9.2

  • Operating System: Linux

  • Node.js version: v12.18.2

  • Browser: Chromium 90.0.4421.0

  • Extra: pipenv 11.9.0

    System:
    OS: Linux 5.8 Ubuntu 20.10 (Groovy Gorilla)
    Memory: 1.11 GB / 15.30 GB
    Container: Yes
    Binaries:
    Node: 12.18.2 - /usr/bin/node
    npm: 6.14.8 - /usr/bin/npm
    Languages:
    Bash: 5.0.17 - /usr/bin/bash

Code Snippet

Snip generated by codegen:

    # Fill input
    page.fill("input", "playwright")
    # Press AltGraph
    page.press("input", "AltGraph")
    # Fill input
    page.fill("input", "[email protected]")

Describe the bug

When typing an email address into an input, codegen creates a fill command up to the @, then inserts an AltGraph keypress, then continues with the final fill command.

IMO Codegen should try to avoid the extra commands. Without copy-paste the user will always have to use AltGr to write the @ but the browser should not receive it as a separate keypress I guess. A developer could still insert it manually if required for some special case.

@pavelfeldman
Copy link
Member

What is your keyboard layout?

@black-silence
Copy link
Author

XKBMODEL="pc105"
XKBLAYOUT="de"
XKBVARIANT="nodeadkeys"
XKBOPTIONS=""

Standard Qwertz with nodeadkeys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants