Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refreshing the page when in debug mode should re-start the test #19251

Closed
pastelsky opened this issue Dec 3, 2022 · 3 comments
Closed

Comments

@pastelsky
Copy link
Contributor

pastelsky commented Dec 3, 2022

Currently, when iterating on an integration test or a component test, it is natural to run playwright in --debug mode.

When doing so, if I hit a reload on the debug browser screen that loads the component / webpage, playwright runs into an inconsistent state.

  1. For component tests, hitting reload means that the page after reload is blank as component mount is never called again.
  2. For normal integration tests, I noticed that execution isn't reset.

Neither of these are great. Ideally, playwright might want to capture reload, and re-start the test. A similar behaviour is seen in other frameworks like cypress and is quite helpful for quick iteration.

I'm happy to submit a fix, in-case there's some guidance on where the fix will lie.

@aslushnikov
Copy link
Collaborator

@pastelsky we discussed this on a team meeting and we found this proposal very interesting, yet not a high priority for now.

@pastelsky
Copy link
Contributor Author

pastelsky commented Dec 6, 2022

Thanks for taking a look! I think this is a part of the larger story to make authoring and iterating on tests in playwright as fun as running it is, as stated by some of the other suggestions —

#15014
#7035

@pavelfeldman
Copy link
Member

Why was this issue closed?

Thank you for your involvement. This issue was closed due to limited engagement (upvotes/activity), lack of recent activity, and insufficient actionability. To maintain a manageable database, we prioritize issues based on these factors.

If you disagree with this closure, please open a new issue and reference this one. More support or clarity on its necessity may prompt a review. Your understanding and cooperation are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants