From 0a49c05e2d12402fae953845e01384a307ecd5f9 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Thu, 5 Sep 2024 12:13:09 +0200 Subject: [PATCH] chore(test runner): document that --only-changed on CI needs history (#32461) Closes https://github.com/microsoft/playwright/issues/32452 `--only-changed=$GITHUB_BASE_REF` needs the base ref available locally to work properly. `fetch-depth: 0` does that, see https://github.com/actions/checkout?tab=readme-ov-file#fetch-all-history-for-all-tags-and-branches. --------- Signed-off-by: Simon Knott Co-authored-by: Dmitry Gozman --- docs/src/ci.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/src/ci.md b/docs/src/ci.md index 7a08a00b4abdd..97ea4ad8d2447 100644 --- a/docs/src/ci.md +++ b/docs/src/ci.md @@ -432,6 +432,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + with: + # Force a non-shallow checkout, so that we can reference $GITHUB_BASE_REF. + # See https://github.com/actions/checkout for more details. + fetch-depth: 0 - uses: actions/setup-node@v4 with: node-version: 18 @@ -1044,4 +1048,4 @@ xvfb-run mvn test ``` ```bash csharp xvfb-run dotnet test -``` \ No newline at end of file +```