-
Notifications
You must be signed in to change notification settings - Fork 32
security(deps): bump the training-dependencies group across 1 directory with 69 updates #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,22 +4,22 @@ version = "0.1.0" | |
| description = "RL training workflow runtime dependencies" | ||
| requires-python = ">=3.12" | ||
| dependencies = [ | ||
| "numpy==1.26.4", | ||
| "numpy==2.4.4", | ||
| "azure-core==1.39.0", | ||
| "azure-storage-blob==12.28.0", | ||
| "azure-identity==1.25.3", | ||
| "azure-ai-ml==1.32.0", | ||
| "marshmallow==3.26.2", | ||
| "marshmallow==4.3.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. marshmallow 3 → 4 (breaking API changes)
Review the [marshmallow 4.0 migration guide]((marshmallow.readthedocs.io/redacted) and confirm no ML job submission or model logging code depends on removed 3.x API surface. |
||
| "mlflow==3.11.1", | ||
| "packaging==26.1", | ||
| "packaging==26.2", | ||
| "psutil==7.2.2", | ||
| "pynvml==13.0.1", | ||
| "pyperclip==1.11.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cryptography 46 → 47 (security update)
Source: [cryptography changelog]((cryptography.io/redacted) |
||
| "cryptography==46.0.7", | ||
| "cryptography==47.0.0", | ||
| "pyjwt==2.12.1", | ||
| "rsl-rl-lib==5.0.1", | ||
| "rsl-rl-lib==5.2.0", | ||
| "skrl==2.0.0", | ||
| "tensordict==0.12.1", | ||
| "tensordict==0.12.2", | ||
| ] | ||
|
|
||
| [build-system] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy==2.4.4is a major version bump (1.x → 2.x) that directly violates the hard pin intraining/rl/scripts/train.sh:uv pip install --upgrade "numpy>=1.26.0,<2.0.0"train.shenforces<2.0.0at runtime to satisfy Isaac Sim's ABI requirements. At execution time,train.shfirst installs a1.xnumpy, thenuv pip install --no-deps -r requirements.txtre-installsnumpy==2.4.4, leaving 2.x on the path. This will causeCUDA_ERROR_NO_DEVICEor silent numerical failures in Isaac Lab environments.Resolution: Update the
train.shpin constraint first and validate against Isaac Sim 4.x before merging. If numpy 2.x is not yet supported by Isaac Sim, revert this single line to"numpy==1.26.4"and exclude numpy from this grouped bump.