Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for In Memory Buffer to GUI #301

Open
shortspider opened this issue Jul 6, 2017 · 3 comments
Open

Add Option for In Memory Buffer to GUI #301

shortspider opened this issue Jul 6, 2017 · 3 comments

Comments

@shortspider
Copy link

Hi,

I'd like to add the option to have an in memory buffer when using the GUI. When using the command line you can specify the size of the circular buffer and if the buffer should be on disk or in memory. However, when using the GUI there is only an option to pick the size of the buffer.

I'd like to add a checkbox next to the buffer size box that allows the buffer to be in memory. It will be unchecked by default (keeping the current behavior).

Does this change sound OK?

@felipepessoto
Copy link
Contributor

+1. I always receive this kind of errors:


Lost Events

WARNING: There were 2386914 lost events in the trace.

Some analysis might be invalid.

Use /InMemoryCircularBuffer or /BufferSize:256 to avoid this in future traces.

OK Cancel

@brianrob
Copy link
Member

@shortspider, thank you for your feedback. This sounds reasonable, but is likely to be one of those things that will require community support. Are you interested in submitting a PR for this?

@stormouse
Copy link

I have added the InMemoryCircularBuffer to run command dialog. Please check out MR:
#1221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants