Skip to content

[QNN-EP] Add support for Sum operator with 2 inputs #24098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HectorSVC merged 1 commit into from
Mar 20, 2025
Merged

[QNN-EP] Add support for Sum operator with 2 inputs #24098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions onnxruntime/core/providers/qnn/builder/op_builder_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ OpBuilderRegistrations::OpBuilderRegistrations() {
CreateSimpleOpBuilder("Sin", *this);
CreateSimpleOpBuilder("Sqrt", *this);
CreateSimpleOpBuilder("Sub", *this);
CreateSimpleOpBuilder("Sum", *this);
CreateSimpleOpBuilder("Tanh", *this);

CreateSimpleOpBuilder("Concat", *this);
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/core/providers/qnn/builder/opbuilder/base_op_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ class BaseOpBuilder : public IOpBuilder {
{"Softmax", QNN_OP_SOFTMAX},
{"Sqrt", QNN_OP_ELEMENT_WISE_SQUARE_ROOT},
{"Sub", QNN_OP_ELEMENT_WISE_SUBTRACT},
{"Sum", QNN_OP_ELEMENT_WISE_ADD},
{"Tanh", QNN_OP_TANH},
{"Transpose", QNN_OP_TRANSPOSE},
{"GridSample", QNN_OP_GRID_SAMPLE},
Expand Down
13 changes: 10 additions & 3 deletions onnxruntime/core/providers/qnn/builder/opbuilder/simple_op_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,18 @@ Status SimpleOpBuilder::ExplicitOpCheck(QnnModelWrapper& qnn_model_wrapper,
padding_mode.c_str());
}

// ONNX's Min and Max operators accept a variable number of inputs (i.e., variadic).
// However, QNN's Min and Max operators must take in exactly two inputs.
// ONNX's Min, Max, and Sum operators accept a variable number of inputs (i.e., variadic).
// However, QNN's Min, Max, and Add operators must take in exactly two inputs.
if (op_type == "Min" || op_type == "Max") {
ORT_RETURN_IF_NOT(node_unit.Inputs().size() == 2,
"QNN EP only supports Min and Max operators with exactly 2 inputs.");
"QNN EP only supports ", op_type.c_str(), " operator with exactly 2 inputs.");
}

if (op_type == "Sum") {
size_t inputs_num = node_unit.Inputs().size();
ORT_RETURN_IF_NOT(inputs_num == 2,
"QNN EP supports Sum operator with QNN_OP_ELEMENT_WISE_ADD, which takes exactly 2 inputs. Got ONNX's Sum operator with ",
std::to_string(inputs_num).c_str(), " inputs.");
}

if (op_type == "DequantizeLinear") {
Expand Down
Loading