Skip to content

Fix a security warning #18979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snnn merged 2 commits into from
Jul 11, 2025
Merged

Fix a security warning #18979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319cbe6
Fix a security warning
wschin Jan 2, 2024
9294d12
Another place
wschin Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...st/Microsoft.ML.OnnxRuntime.EndToEndTests.Mobile/EndToEndTests.Mobile.Automation/Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ public void RunPlatformUnitTest()
var serializedResultSummary = _app.Invoke(_getResultsBackdoorMethodName)?.ToString();
Assert.IsNotEmpty(serializedResultSummary, "Test results were not returned");

// Fix security issue (overflow with too much nesting): GHSA-5crp-9r3c-p9vr
JsonConvert.DefaultSettings = () => new JsonSerializerSettings { MaxDepth = 128 };
var testSummary = JsonConvert.DeserializeObject<TestResultSummary>(serializedResultSummary);
Assert.AreEqual(testSummary.Failed, 0, $"{testSummary.Failed} tests failed");

_app.Screenshot("Post-testing");
}
}
}
}
3 changes: 2 additions & 1 deletion csharp/test/Microsoft.ML.OnnxRuntime.Tests.Devices/TestResultProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public TestResultSummary GetResults()
public string GetSerializedResults()
{
var resultSummary = GetResults();
JsonConvert.DefaultSettings = () => new JsonSerializerSettings { MaxDepth = 128 };
var serializedResultSummary = JsonConvert.SerializeObject(resultSummary, Formatting.Indented);
return serializedResultSummary;
}
}
}
}
Loading