Skip to content

RoiAlign CPU EP add warning for max mode with samples != 1 #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdwr merged 3 commits into from
Jul 12, 2022
Merged

RoiAlign CPU EP add warning for max mode with samples != 1 #12136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f53ddc
RoiAlign add warning about incorrect max summation when sample size n…
fdwr Jul 9, 2022
93f4a92
Avoid read AV, as the kernel is overly trusting of the batch indices …
fdwr Jul 9, 2022
f981951
Split out warning into separate PR
fdwr Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion onnxruntime/core/providers/cpu/object_detection/roialign.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class RoiAlignBase {
} else {
ORT_THROW("Invalid mode of value ", mode, " specified. It should be either avg or max");
}
mode_ = mode == "avg" ? RoiAlignMode::avg : RoiAlignMode::max;
}

// output_height
Expand Down Expand Up @@ -64,6 +63,13 @@ class RoiAlignBase {
else
half_pixel_ = false;
}

if (mode_ == RoiAlignMode::max && sampling_ratio_ != 1) {
// TODO(fdwr): Issue #6146. ORT 1.13 will correct the incorrect summation of max mode with PR #7354.
LOGS_DEFAULT(WARNING) << "The existing summation for max mode and sampling ratios besides 1 is incorrect "
<< "and will be fixed in the next ORT 1.13 release. Thus the results of RoiAlign "
<< "will be different.";
}
}

protected:
Expand Down