Skip to content

Set add_special_tokens to false by default in Encode #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanUnderhill merged 4 commits into from
May 2, 2025
Merged

Set add_special_tokens to false by default in Encode #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4bd10b
add tokenize with special tokens api changes
May 2, 2025
7fa3dcd
lint check
May 2, 2025
1b1dead
remove new method, set param by default in encode
May 2, 2025
59f79bd
label bool for readability
sayanshaw24 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/deps.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ pybind11;https://github.com/pybind/pybind11/archive/refs/tags/v2.13.6.zip;f78029
googletest;https://github.com/google/googletest/archive/530d5c8c84abd2a46f38583ee817743c9b3a42b4.zip;5e3a61db2aa975cfd0f97ba92c818744e7fa7034
microsoft_wil;https://github.com/microsoft/wil/archive/refs/tags/v1.0.230629.1.zip;e4a542a323c070376f7c2d1973d0f7ddbc1d2fa5
directx_headers;https://github.com/microsoft/DirectX-Headers/archive/refs/tags/v1.613.1.zip;47653509a3371eabb156360f42faf582f314bf2e
onnxruntime_extensions;https://github.com/microsoft/onnxruntime-extensions.git;d1daadcb53a80645b3d96218e4713f24c12dfaf0
onnxruntime_extensions;https://github.com/microsoft/onnxruntime-extensions.git;fc004859e82241e99d458a90d2a39d400050cc59
1 change: 0 additions & 1 deletion src/csharp/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ public static extern UIntPtr OgaSequencesGetSequenceCount(IntPtr /* const OgaSeq
byte[] /* const char* */ strings,
IntPtr /* OgaSequences* */ sequences);


// This function is used to decode the given token into a string. The caller is responsible for freeing the
// returned string using the OgaDestroyString function when it is no longer needed.
[DllImport(NativeLib.DllName, CallingConvention = CallingConvention.Winapi)]
Expand Down
2 changes: 1 addition & 1 deletion src/models/model.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ std::unique_ptr<TokenizerStream> Tokenizer::CreateStream() const {

std::vector<int32_t> Tokenizer::Encode(const char* text) const {
OrtxPtr<OrtxTokenId2DArray> ids;
CheckResult(OrtxTokenize(tokenizer_, &text, 1, ids.Address()));
CheckResult(OrtxTokenizeWithOptions(tokenizer_, &text, 1, ids.Address(), false /* add_special_tokens */));

const extTokenId_t* tokens;
size_t count;
Expand Down
Loading