From 611d1996ed97580ee800a537835a9a2bc1d67a54 Mon Sep 17 00:00:00 2001 From: Noah McGregor Harper <74685766+nharper285@users.noreply.github.com> Date: Mon, 6 Mar 2023 22:34:18 +0000 Subject: [PATCH 1/2] Add additional filter check for reports and regressions. --- src/ApiService/ApiService/onefuzzlib/Reports.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ApiService/ApiService/onefuzzlib/Reports.cs b/src/ApiService/ApiService/onefuzzlib/Reports.cs index 1a24106119..58dde1ad75 100644 --- a/src/ApiService/ApiService/onefuzzlib/Reports.cs +++ b/src/ApiService/ApiService/onefuzzlib/Reports.cs @@ -28,9 +28,9 @@ public Reports(ILogTracer log, IContainers containers) { public async Async.Task GetReportOrRegression(Container container, string fileName, bool expectReports = false, params string[] args) { var filePath = string.Join("/", new[] { container.String, fileName }); - if (!fileName.EndsWith(".json", StringComparison.Ordinal)) { + if (!fileName.EndsWith(".json", StringComparison.Ordinal) || fileName.Contains("source-coverage", StringComparison.Ordinal)) { if (expectReports) { - _log.Error($"get_report invalid extension: {filePath:Tag:FilePath}"); + _log.Error($"get_report invalid extension or filename: {filePath:Tag:FilePath}"); } return null; } From f1f8e5c1707addd7c49ee598b17c1fde8bb5433d Mon Sep 17 00:00:00 2001 From: Noah McGregor Harper <74685766+nharper285@users.noreply.github.com> Date: Mon, 6 Mar 2023 22:51:50 +0000 Subject: [PATCH 2/2] Change comparator option. --- src/ApiService/ApiService/onefuzzlib/Reports.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ApiService/ApiService/onefuzzlib/Reports.cs b/src/ApiService/ApiService/onefuzzlib/Reports.cs index 58dde1ad75..dd0f7e741e 100644 --- a/src/ApiService/ApiService/onefuzzlib/Reports.cs +++ b/src/ApiService/ApiService/onefuzzlib/Reports.cs @@ -28,7 +28,7 @@ public Reports(ILogTracer log, IContainers containers) { public async Async.Task GetReportOrRegression(Container container, string fileName, bool expectReports = false, params string[] args) { var filePath = string.Join("/", new[] { container.String, fileName }); - if (!fileName.EndsWith(".json", StringComparison.Ordinal) || fileName.Contains("source-coverage", StringComparison.Ordinal)) { + if (!fileName.EndsWith(".json", StringComparison.Ordinal) || fileName.Contains("source-coverage", StringComparison.InvariantCultureIgnoreCase)) { if (expectReports) { _log.Error($"get_report invalid extension or filename: {filePath:Tag:FilePath}"); }