This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Sets EnableScriban to false by default at deployment time
#2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamL-Microsoft
approved these changes
Feb 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #2839 +/- ##
=======================================
Coverage 29.87% 29.87%
=======================================
Files 324 324
Lines 39062 39062
=======================================
Hits 11671 11671
Misses 27391 27391 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
The scriban migration cli trigger wasn't shipped in 6.4. If EnableScriban is enabled at deployment time, we would need to run the migration before the deployment.
This way, we can run the migration after deploying 7.0, and then flip the feature flag afterwards.