Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ES6 intellisense #613

Closed
SteveALee opened this issue Nov 22, 2015 · 4 comments
Closed

New ES6 intellisense #613

SteveALee opened this issue Nov 22, 2015 · 4 comments

Comments

@SteveALee
Copy link

I'm using node 4.x.x and the built in ES6 features like const and template strings. Currently this seems to be unsupported in intellisense

  1. The maximum intellisense option doesn't recognise const and highlights ` as an error
  2. The ES6 intellisense support appears to just show 'any' for everything.

The problem with adding Definitely Typed definitions is they are community maintained For Hapi the file is very out of date so not really much use. Plus it's a real pain to manually insert and manage the references in each file.

I think an approach that supports ES6 without manual management of definitely Type refs is required.

@mousetraps
Copy link
Contributor

Thx for the feedback! Yeah, unfortunately we're taking a step back here in the interest of taking a couple steps forward... See our current discussion on this topic: #488

Regarding max intellisense... we actually do support const & let, but yes - syntax highlighting for most everything else is missing 😦

@SteveALee
Copy link
Author

Are you suggesting the need for explicitly DT refs will removed in time? That requirement is bit of deal breaker for me. I seem to recall @code required them in the first release but it may have been removed later?

I fully agree with the desire to collaborate with other efforts in this area. But, I'd like to avoid the extra work of managing explicit DT refs, especially as I tend to have many small source files

Can you point me at good introductory docs for the new TS intellisense? I've been trying it with more substantial code and am seeing more useful intellisense now. However, there's still lots of unknowns and 'any's compared with the full NTVS intellisense.

If it's faster that will be a boost, though latest full NTVS intellisense is pretty good now.

The ability to browse using the top combos is a nice extra.

@billti
Copy link
Member

billti commented Nov 23, 2015

Tracking this discussion in #488

@billti billti closed this as completed Nov 23, 2015
@SteveALee
Copy link
Author

##Weird behaviour with ES6 intellisense enabled. ##
I assume it's intellisense as I have disabled all extensions I could and there is no source of the errors given. I set the project to autoload on startup.

  1. clean project to empty errors list
  2. Save the file or simply close and open error list again

image

Line 16 is

internals.webBaseURL = http://${internals.serverHost}:${internals.serverPort};
and as we can see it's correctly syntax highlighting the backtick template string.

My guess is it's parsing without ES6 on.

If I then double click on the error it get this
image

And if I answer 'yes' then the intellisense boxes at the top of the file disappear and the syntax highlighting indicates it doesn't like the backtick character - as per the error.

image

If I then double click on the file in solution explorer I get the message box again and the intellisense reverts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants