Support node 16.20+

[studentofcoding]

Environment details

• OS: MacOs M1
• OS version: Sonoma 14.5
• node-pty version: [email protected]

Issue description

The build has thrown up an error on node16.20.x

[13/14] ⠈ node-pty
warning Error running install script for optional dependency: "/Users/gic_owner/Desktop/Personal/GIC_Capital/Contractor/challenge/node_modules/node-pty: Command failed.
Exit code: 1
Command: node scripts/install.js
Arguments: 
Directory: /Users/gic_owner/Desktop/Personal/GIC_Capital/Contractor/challenge/node_modules/node-pty
Output:
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | arm64
gyp info find Python using Python version 3.10.8 found at \"/Users/gic_owner/miniforge3/bin/python3\"
gyp info spawn /Users/gic_owner/miniforge3/bin/python3
gyp info spawn args [
gyp info spawn args   '/Users/gic_owner/.nvm/versions/node/v16.20.2/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/gic_owner/Desktop/Personal/GIC_Capital/Contractor/challenge/node_modules/node-pty/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/gic_owner/.nvm/versions/node/v16.20.2/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/gic_owner/Library/Caches/node-gyp/16.20.2',
gyp info spawn args   '-Dnode_gyp_dir=/Users/gic_owner/.nvm/versions/node/v16.20.2/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/gic_owner/Library/Caches/node-gyp/16.20.2/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/gic_owner/Desktop/Personal/GIC_Capital/Contractor/challenge/node_modules/node-pty',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from ../src/unix/pty.cc:20:
In file included from ../../nan/nan.h:62:
In file included from /Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/node.h:73:
In file included from /Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8.h:30:
/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8-internal.h:492:50: error: 'T' does not refer to a value
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                                 ^
/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8-internal.h:489:17: note: declared here
template <class T>
                ^
/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8-internal.h:492:38: error: no member named 'remove_cv_t' in namespace 'std'; did you mean 'remove_if'?
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                ~~~~~^~~~~~~~~~~
                                     remove_if
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/remove_if.h:24:1: note: 'remove_if' declared here
remove_if(_ForwardIterator __first, _ForwardIterator __last, _Predicate __pred)
^
In file included from ../src/unix/pty.cc:20:
In file included from ../../nan/nan.h:62:
In file included from /Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/node.h:73:
In file included from /Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8.h:30:
/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8-internal.h:492:52: error: expected '(' for function-style cast or type construction
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/Users/gic_owner/Library/Caches/node-gyp/16.20.2/include/node/v8-internal.h:492:63: error: no member named 'Perform' in the global namespace
            !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
                                                            ~~^
4 errors generated.
make: *** [Release/obj.target/pty/src/unix/pty.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/gic_owner/.nvm/versions/node/v16.20.2/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:201:23)
gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
gyp ERR! System Darwin 23.5.0
gyp ERR! command \"/Users/gic_owner/.nvm/versions/node/v16.20.2/bin/node\" \"/Users/gic_owner/.nvm/versions/node/v16.20.2/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"
gyp ERR! cwd /Users/gic_owner/Desktop/Personal/GIC_Capital/Contractor/challenge/node_modules/node-pty
✨  Done in 19.22s.

[Tyriar]

Node 16 is end of life, security support ended for the LTS over a year ago https://endoflife.date/nodejs