Adding support for supplementary groups for Linux #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="CodeSignal" |
Tyriar
requested changes
Jun 7, 2024
README.md
Outdated
| @@ -31,7 +31,7 @@ const ptyProcess = pty.spawn(shell, [], { | |||
| env: process.env | |||
| }); | |||
|
|
|||
| ptyProcess.onData((data) => { | |||
There was a problem hiding this comment.
Why did you change this? on was deprecated some time ago and I don't think it's in the .d.ts anymore
There was a problem hiding this comment.
Oh, I made that change based on ITerminal from src/interfaces.ts. Reverted it back
|
Hi @Tyriar I addressed your comment. Can you review the PR again? |
|
I assigned @deepak1556 to review, my comment was just a drive-by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #684
Changes
Functional
suppGidsparameter fornode-pty.spawnthat allows to provide supplementary group IDs for Linux. The parameter will take effect only ifgidanduidare provided.Technical
READMEexample.