Can't pty.kill() or pty.destroy() on Windows 10

[matheuss]

Whenever I try to kill a pty process with pty.kill() or pty.destroy(), the whole parent process just crashes:

The same happens inside Hyper:

I wasn't able to get any relevant logs anywhere, not even on Event Viewer.

A try-catch is useless:

try {
  pty.kill();
} catch (err) {
  console.error(err);
}

The error never gets printed – the parent process just crashes.

If I pty._close(), everything works fine. I cannot reproduce this on macOS or Linux.

Any ideas? 😥

[Tyriar]

I'll have a look, winpty agent probably isn't being cleaned up properly.

[matheuss]

@Tyriar thank you ❤️ Do you think it's safe to ship Hyper with pty._close() on Windows?

[Tyriar]

I'd avoid shipping just yet as I'll look into this today/tomorrow. FYI I also published 0.6.1 which corrects the compiled JS to fix the Git Bash backspace issue so you can test with that in the meantime. https://github.com/Tyriar/node-pty/releases/tag/0.6.1

[matheuss]

Same issue on 0.6.1 😕 Will push pty._close() as a temporary workaround then. Thank you again!

[Tyriar]

Yep I can repro and have a test, working on fix now.

    it("should not crash parent process", function(done) {
      const term = new WindowsTerminal('cmd.exe', [], {});
      term.kill();
      // Add done call to deferred function queue to ensure the kill call has completed
      term._defer(done);
    });

[matheuss]

Amazing @Tyriar ❤️ Any ETA for the release?

[Tyriar]

I'll probably release it later today, need to do some verification first.

[Tyriar]

@matheuss actually it would be ideal if you could also verify using [email protected] 😄

[matheuss]

@Tyriar Perfect 💯

[Tyriar]

Published https://github.com/Tyriar/node-pty/releases/tag/0.6.2

[matheuss]

@Tyriar you're amazing ❤️

[LabhanshAgrawal]

@Tyriar the typings mention

node-pty/typings/node-pty.d.ts

Lines 179 to 185 in cd72d33

	/**
	* Kills the pty.
	* @param signal The signal to use, defaults to SIGHUP. This parameter is not supported on
	* Windows.
	* @throws Will throw when signal is used on Windows.
	*/
	kill(signal?: string): void;

Is the type doc incorrect?

[LabhanshAgrawal]

Oops, sorry I misunderstood the @throws stuff, please ignore it.