Skip to content

Commit 7125d38

Browse files
committed
Elaborate on experimentalUseConpty setting
1 parent 2d3c8de commit 7125d38

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/interfaces.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export interface IPtyForkOptions {
116116
uid?: number;
117117
gid?: number;
118118
encoding?: string;
119-
experimentalUseConpty?: boolean;
119+
experimentalUseConpty?: boolean | undefined;
120120
}
121121

122122
export interface IPtyOpenOptions {

typings/node-pty.d.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/**
22
* Copyright (c) 2017, Daniel Imms (MIT License).
3+
* Copyright (c) 2018, Microsoft Corporation (MIT License).
34
*/
45

56
declare module 'node-pty' {
@@ -26,8 +27,10 @@ declare module 'node-pty' {
2627
gid?: number;
2728
encoding?: string;
2829
/**
29-
* Whether to use the experimental ConPTY system on Windows. This setting will be ignored on
30-
* non-Windows.
30+
* Whether to use the experimental ConPTY system on Windows. When this is not set, ConPTY will
31+
* be used when the Windows build number is >= 17692.
32+
*
33+
* This setting does nothing on non-Windows.
3134
*/
3235
experimentalUseConpty?: boolean;
3336
}

0 commit comments

Comments
 (0)