Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

sort NaN trials furthest from optimal trials in WebUI #2775

Closed
yhidaka opened this issue Aug 7, 2020 · 3 comments
Closed

sort NaN trials furthest from optimal trials in WebUI #2775

yhidaka opened this issue Aug 7, 2020 · 3 comments
Labels
enhancement New feature or request user raised

Comments

@yhidaka
Copy link

yhidaka commented Aug 7, 2020

Currently NaN appears to be treated as zero when sorting the "Default metric" column in WebUI. (I'm using NNI v1.6 by the way.)

This becomes an issue, for example, when you have a minimization problem with non-NaN metrics being always positive. After sorting in the ascending order, if you have many NaN cases, you'll have to scroll down a lot to see the best (minimal) metric. You will encounter the same issue even you sort in the descending order.

Since NaN is always undesirable, it would be nice if NaN is treated as positive infinity for minimization problems, while treated as negative infinity for maximization problems, for the WebUI sorting purpose only

@scarlett2018
Copy link
Member

@Lijiaoa - this issue is fixed in #2776 and will be released in the Aug iteration, right? thanks.

@scarlett2018 scarlett2018 added user raised enhancement New feature or request labels Aug 12, 2020
@Lijiaoa
Copy link
Contributor

Lijiaoa commented Aug 24, 2020

@scarlett2018 @yhidaka PR #2776 is closed by some reasons. But this issue had been fixed in PR #2773, will be released in v1.8!

@kvartet
Copy link
Contributor

kvartet commented Dec 7, 2020

I’m closing this issue as we have fixed the problem you raised, please feel free to reopen if you are still seeing it an active issue.

@kvartet kvartet closed this as completed Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request user raised
Projects
None yet
Development

No branches or pull requests

4 participants