Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting perf improvements from muP at ~1.5B scale #76

Open
gordicaleksa opened this issue Jul 19, 2024 · 0 comments
Open

Not getting perf improvements from muP at ~1.5B scale #76

gordicaleksa opened this issue Jul 19, 2024 · 0 comments

Comments

@gordicaleksa
Copy link

gordicaleksa commented Jul 19, 2024

Hey guys, first of all thanks for the awesome work!

I've implemented muP in the llm.c project (see here), the coord checks seem to be flat / correct (I went up to 15 steps and still flat!) but I am not getting any performance improvement using mup?

Could it be that this is due to smaller scale? We're testing it on 1.5B LLMs. Should we expect a different behavior at ~7B?

I wrote up a mini document on what i've done to support mup in llm.c here under mup.md.

Am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant