Revert "Fix issues identified by SonarQube (#929)" #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a38e970. # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerParameterMetaData.java # src/main/java/com/microsoft/sqlserver/jdbc/SimpleInputStream.java
rene-ye
previously approved these changes
Jan 15, 2019
rene-ye
reviewed
Jan 16, 2019
Member
There was a problem hiding this comment.
Excess brackets, but not a needed change.
rene-ye
reviewed
Jan 16, 2019
Member
There was a problem hiding this comment.
return (int) info.get(PRECISION);
rene-ye
reviewed
Jan 16, 2019
cheenamalhotra
force-pushed
the
redoPR929
branch
from
c812850 to
a387718
Compare
rene-ye
approved these changes
Jan 16, 2019
peterbae
approved these changes
Jan 16, 2019
Codecov Report
@@ Coverage Diff @@
## dev #935 +/- ##
============================================
- Coverage 50.53% 50.45% -0.09%
+ Complexity 2918 2911 -7
============================================
Files 120 120
Lines 28009 27984 -25
Branches 4682 4678 -4
============================================
- Hits 14155 14119 -36
- Misses 11559 11575 +16
+ Partials 2295 2290 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.