Stored procedure call returns wrong BigDecimal scale. #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ananya2
changed the title
Ananya2
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
============================================
+ Coverage 50.99% 51.08% +0.09%
- Complexity 3911 3925 +14
============================================
Files 147 147
Lines 33456 33480 +24
Branches 5604 5609 +5
============================================
+ Hits 17060 17103 +43
+ Misses 13992 13967 -25
- Partials 2404 2410 +6 ☔ View full report in Codecov by Sentry. |
machavan
reviewed
Dec 9, 2024
divang
reviewed
Dec 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Dec 9, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Outdated
Show resolved
Hide resolved
tkyc
reviewed
Dec 9, 2024
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
|
pinged you about an internal test fail |
lilgreenbird
requested changes
Dec 9, 2024
machavan
reviewed
Dec 16, 2024
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BigDecimalPrecisionTest.java
Outdated
Show resolved
Hide resolved
|
There should be significant comments in code, so that a new person can understand the code. |
|
lilgreenbird
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Show resolved
Hide resolved
lilgreenbird
requested changes
Jan 7, 2025
divang
approved these changes
Jan 8, 2025
tkyc
approved these changes
Jan 10, 2025
Set scale value dynamically for DECIMAL output parameters in registerOutParameter method. This change retrieves the scale from the ParameterMetaData and applies it to the DECIMAL output parameter. This provides a more flexible approach for handling DECIMAL data types. As an alternative, users can directly call registerOutParameter(index, sqlType, scale) to specify the scale explicitly.
… DECIMAL type parameter.
…in the dynamic handling of DECIMAL output parameters.
Ananya2
force-pushed
the
users/anagarg/issue#2534
branch
from
cb7d65a to
b2d7c07
Compare
|
Changes have already been requested as a part of #2582, hence closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2534 - Set scale value dynamically for DECIMAL output parameters in registerOutParameter method.
This change retrieves the scale from the ParameterMetaData and applies it to the DECIMAL output parameter. This provides a more flexible approach for handling DECIMAL data types.
As an alternative, users can directly call registerOutParameter(index, sqlType, scale) to specify the scale explicitly.