Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findMatches, findNextMatch and findPreviousMatch have incorrect typings #580

Closed
gatesn opened this issue Sep 7, 2017 · 2 comments
Closed

findMatches, findNextMatch and findPreviousMatch have incorrect typings #580

gatesn opened this issue Sep 7, 2017 · 2 comments

Comments

@gatesn
Copy link

gatesn commented Sep 7, 2017

https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.ireadonlymodel.html#findmatches

The docs state to pass null for wordSeparators to avoid forcing full word matches, but the typings do not allow nulls.
@alexdima
Copy link
Member

alexdima commented Nov 13, 2017 •
edited
Loading

PR welcome.

@rcjsuen rcjsuen mentioned this issue Feb 25, 2018
Merged
@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 7, 2018 •
edited
Loading

I think this can be closed since microsoft/vscode#44353 got merged. Thanks for the help, @alexandrudima!

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gatesn @alexdima @rcjsuen