Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test pipeline for Monaco Editor #1668

Closed
3 tasks done
rebornix opened this issue Nov 8, 2019 · 3 comments
Closed
3 tasks done

Build/Test pipeline for Monaco Editor #1668

rebornix opened this issue Nov 8, 2019 · 3 comments
Assignees

Comments

@rebornix
Copy link
Member

rebornix commented Nov 8, 2019

Right now we majorly rely on maintainers to do testing and sanity checks before every release manually. Considering that we now support both AMD and ESM and we have 5 built in extensions shipped with Monaco Editor, an automatic build and test pipeline can help us avoid shipping broken bits as much as possible.

  • Fetch master from VS Code and build Monaco Editor core from it
    • Throw when build and tree shaking fails
  • Test the core and ensure the basic functionalities work

CI configuration is defined in https://github.com/microsoft/monaco-editor/blob/master/.github/workflows/ci.yml

@orta
Copy link
Contributor

orta commented Nov 12, 2019

I don't think it'll be too useful for you, but you might be able to take some of my work form https://github.com/orta/make-monaco-builds

@rebornix
Copy link
Member Author

@orta thanks, I like the nightly build setup, only one question, it will publish monaco-editor nightly with monaco-editor-core from NPM and TypeScript nightly, right? In my setup, it's the other way around: we bundle monaco-editor-core from vscode master and monaco-typescript from NPM, run tests against it to see if there are any potential bugs.

@rebornix
Copy link
Member Author

rebornix commented Dec 6, 2019

Shipped.

@rebornix rebornix closed this as completed Dec 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants