From 51cd26e91f4b3a18738935cccdcb91a36f745d4c Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Thu, 11 Jan 2024 12:47:45 -0800 Subject: [PATCH 1/3] fix bad links --- docs/contribution_workflow.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/contribution_workflow.md b/docs/contribution_workflow.md index 7cd035e817..54b752d7e3 100644 --- a/docs/contribution_workflow.md +++ b/docs/contribution_workflow.md @@ -27,13 +27,12 @@ have one). from upstream. They also enable you to create multiple PRs from the same fork. 4. Make and commit your changes. - * Please follow our [Commit Messages](contribution_workflow.md#Commit-Messages) + * Please follow our [Commit Messages](#Commit-Messages) guidance. -5. Add [new tests](developer_guide.md#Testing) corresponding to your change, if applicable. +5. Add new tests corresponding to your change, if applicable. 6. Build the repository with your changes. * Make sure that the builds are clean. - * Make sure that the [tests](developer_guide.md#Testing) are all passing, including your new - tests. + * Make sure that the tests are all passing, including your new tests. 7. Create a pull request (PR) against the upstream repository's main branch. * Push your changes to your fork on GitHub (if you haven't already). - Note: It is okay for your PR to include a large number of commits. Once From cfed717c568b8b43a22a1126aa406b811435660b Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Thu, 11 Jan 2024 13:00:46 -0800 Subject: [PATCH 2/3] another doc link validation failure --- docs/contribution_workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contribution_workflow.md b/docs/contribution_workflow.md index 54b752d7e3..9f5b4a12cb 100644 --- a/docs/contribution_workflow.md +++ b/docs/contribution_workflow.md @@ -46,7 +46,7 @@ have one). ## DOs and DON'Ts Please do: -* **DO** follow our [coding style](code_style_and_conventions.md). +* **DO** follow existing coding style. * **DO** give priority to the current style of the project or file you're changing even if it diverges from the general guidelines. * **DO** include tests when adding new features. When fixing bugs, start with From 5e82e42d5e08b99022125878b658fb2a3d07d60e Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Thu, 11 Jan 2024 13:09:37 -0800 Subject: [PATCH 3/3] a few more 404 links --- docs/contribution_workflow.md | 3 +-- docs/triage.md | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/contribution_workflow.md b/docs/contribution_workflow.md index 9f5b4a12cb..bf770734f1 100644 --- a/docs/contribution_workflow.md +++ b/docs/contribution_workflow.md @@ -90,8 +90,7 @@ bot will then trigger the build. In order to have PRs automatically merge once all checks have passed (including optional checks), maintainers can apply the [auto merge](https://github.com/Microsoft/microsoft-ui-xaml/labels/auto%20merge) -label. It will take effect after an 8 hour delay, -[more info here (internal link)](https://microsoft.sharepoint.com/teams/FabricBot/SitePages/AutoMerge,-Bot-Templates-and.aspx). +label. It will take effect after an 8 hour delay. ### Other Pipelines diff --git a/docs/triage.md b/docs/triage.md index 75d952138d..c172b88271 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -77,5 +77,3 @@ We also need to monitor: 1. Remove `needs-triage` when a closed issue has a reply by someone with write access to the repo. 1. Replace `needs-author-feedback` label with `needs-assignee-attention` (if assigned) or `needs-triage` (if unassigned). - -[Admin panel](https://fabric-cp.azurewebsites.net/bot/)