Swapping view model (same type, new instance) that exposes ICustomPropertyProvider does not trigger Bindings update #4913

dim-37 · 2021-04-28T12:28:30Z

In the uploaded semple we replace the current page data context with a new instance of the view model.
The number on the screen in a number of view model instances.

Lunch UWP app on x64
Click on 'To test page' button
Click on 'Reset scope' button
Because the new instances of the main page is created on back stack navigation in frame new bindings propagate new values
Click on 'Reset scope' button
Notice that the number didn’t change because bindings didn’t update
Test Page is bound to view model NavigationView TogglePaneTopPadding issue #2 but the main page updated view model Programmatically adding new NavigationViewItems to an existing NavigationView.MenuItems collection results in the added items rendering inside a generated NavigationViewItem node #1. So sub view model of the test page doesn’t exist in view model NavigationView TogglePaneTopPadding issue #2 hence test page is empty.

Windows app type:

UWP	Win32
Yes

Windows 10 version	Saw the problem?
Insider Build (xxxxx)	Not Tested
October 2020 Update (19042)	Yes
May 2020 Update (19041)	Not Tested
November 2019 Update (18363)	Not Tested
May 2019 Update (18362)	Not Tested
October 2018 Update (17763)	Not Tested
April 2018 Update (17134)	Not Tested
Fall Creators Update (16299)	Not Tested
Creators Update (15063)	Not Tested

Device form factor	Saw the problem?
Desktop	Yes
Xbox	Not Tested
Surface Hub	Not Tested
IoT	Not Tested

Additional context
ErrorReproducing.zip

ranjeshj · 2021-04-28T23:13:31Z

@dim-37 could you provide a simplified repro with just a uwp app ? I'm unable to load and build the attached project.

xperiandri · 2021-04-29T11:26:59Z

@ranjeshj you can remove or unload all the projects except all F#, Elmish, Shared, and UWP

dim-37 · 2021-04-29T14:58:47Z

@ranjeshj Here is the corrected version
How to run :

Open ErrorReproducing\ErrorReproducing.slnf
Build Elmish.Uno.Uwp.
Run ErrorReproducing.UWP
ErrorReproducing.zip

xperiandri · 2021-05-10T18:42:53Z

@ranjeshj were you able to reproduce the issue?

chrisglein · 2021-05-17T22:49:53Z

Looking at the project this appears to be system XAML (UWP), not WinUI3. Clearing that label.

@dim-37 There's a lot going on here with F# and Uno. Is that essential to the repro? Sounds like from the above it's okay to unload them?

Where's the code in your sample that's setting that instance count?

Likely the fix here would need to go in WinUI3, as that's where these sorts of bugs are being fixed. But FYI I don't believe that works with F# (just C# and C++).

xperiandri · 2021-05-18T05:49:02Z

The issue is not about F#.
But about interop of .NET and WinRT

xperiandri · 2021-05-18T16:56:52Z

@chrisglein the last sample is the simplest and smallest one. If you open the solution with SLNF file you will get only 5 projects loaded.

If you want to get rid of F# completely and have a single project you can implement ICustomPropertyProvider in C# as I did in ErrorReproducing\Elmish.Uno\src\Elmish.Uno.Uwp\ViewModel.cs
Just grab my code, remove the base class and put some internal item from which you will return some data.

xperiandri · 2021-05-18T16:58:56Z

WinUI 3 perfectly works with F#. I tested. Modern CS WinRT bindings in .NET 5 support any language

xperiandri · 2021-05-18T17:00:34Z

The bug is somewhere in WinUI implementation. Because the Uno Platform version of WinUI reimplemented in C# works fine, and this bug is not reproduced on Uno.

ghost · 2021-05-25T20:00:04Z

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

xperiandri · 2021-05-25T20:27:46Z

@chrisglein @ranjeshj

chiaramooney · 2021-05-26T18:06:46Z

Just tried the latest zip sent and I'm experiencing loading errors when I open ErrorProducing.sln. None of the projects are able to load into the solution and produced the error "The project file could not be found".

xperiandri · 2021-05-26T19:17:03Z

@chiaramooney can we have your screen sharing session in Microsoft Teams?

xperiandri · 2021-05-31T18:02:01Z

@chiaramooney

xperiandri · 2021-06-07T21:24:41Z

Any updates?

xperiandri · 2021-06-20T23:19:23Z

This now does not work at all in WinUI 0.5.7
Branch https://github.com/xperiandri/Elmish.Uno/tree/uno_winui
ICustomProperty methods are never invoked

runceel · 2021-06-29T00:03:50Z

I have created a minimum project for repro for this issue using C#. I think this project will work on your side, @chiaramooney.

https://github.com/runceel/CustomPropertyProviderApp

The bottom button is replacing DataContext property of the page to new regular ViewModel class.

private void Button_Click2(object sender, RoutedEventArgs e) => DataContext = new MainPageViewModel();

The top button is replacing that to new ViewModel class that is implemented ICustomPropertyProvider interface. The TextBlock was not updated.

private void Button_Click(object sender, RoutedEventArgs e) => DataContext = new CustomPropertyProviderMainPageViewModel();

runceel · 2021-06-29T06:30:52Z

I did try and error to implement ICustomPropertyProvider interface correctly.
I noticed that GetValue method of ICustomProperty has object target argument, and I thought instances of ICustomProperty were cached by UWP data binding engine.

So, I edited the repro project to use the target argument to get property value.
It worked fine.

The project is on correctImplementation branch of the repository.
https://github.com/runceel/CustomPropertyProviderApp/tree/correctImplementation

@xperiandri Could you try that on your project?

xperiandri · 2021-06-29T08:42:08Z

Ah! So this is not a bug but a feature and a lack of proper documentation 😁.
Your new sample works.

I try to fix my Elmish.Uno accordingly. I will post an update after finish

xperiandri · 2021-06-29T14:14:26Z

So I fixed my implementation according to @runceel's fix

using System;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Diagnostics;
using System.Windows.Input;

using Elmish.Uno;

using Microsoft.FSharp.Collections;
using Microsoft.FSharp.Core;

using Windows.UI.Core;
using Windows.UI.Xaml;
using Windows.UI.Xaml.Data;

namespace Elmish.Windows
{
    public class DynamicCustomProperty<TTarget, TValue> : ICustomProperty
    {
        public Func<TTarget, TValue> Getter { get; }
        public Action<TTarget, TValue> Setter { get; }
        public Func<TTarget, object, TValue> IndexGetter { get; }
        public Action<TTarget, object, TValue> IndexSetter { get; }

        public object GetValue(object target) => Getter.Invoke((TTarget) target);
        public void SetValue(object target, object value) => Setter.Invoke((TTarget)target, (TValue)value);
        public object GetIndexedValue(object target, object index) => IndexGetter.Invoke((TTarget)target, index);
        public void SetIndexedValue(object target, object value, object index) => IndexSetter.Invoke((TTarget)target, index, (TValue)value);

        public bool CanRead => Getter != null || IndexGetter != null;
        public bool CanWrite => Setter != null || IndexSetter != null;
        public string Name { get; }
        public Type Type => typeof(TValue);

        public DynamicCustomProperty(string name, Func<TTarget, TValue> getter, Action<TTarget, TValue> setter = null, Func<TTarget, object, TValue> indexGetter = null, Action<TTarget, object, TValue> indexSetter = null)
        {
            Name = name;
            Getter = getter;
            Setter = setter;
            IndexGetter = indexGetter;
            IndexSetter = indexSetter;
        }
    }

    internal class ViewModel<TModel, TMsg> : Uno.ViewModel<TModel, TMsg>, ICustomPropertyProvider
    {
        public ViewModel(TModel initialModel, FSharpFunc<TMsg, Unit> dispatch, FSharpList<Binding<TModel, TMsg>> bindings, ElmConfig config, string propNameChain) : base(initialModel, dispatch, bindings, config, propNameChain) { }

        public override Uno.ViewModel<object, object> Create(object initialModel, FSharpFunc<object, Unit> dispatch, FSharpList<Binding<object, object>> bindings, ElmConfig config, string propNameChain)
         => new ViewModel<object, object>(initialModel, dispatch, bindings, config, propNameChain);

        private ICustomProperty GetProperty(string name)
        {
            if (name == "CurrentModel") return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.CurrentModel);
            if (name == "HasErrors") return new DynamicCustomProperty<ViewModel<TModel, TMsg>, bool>(name, vm => ((INotifyDataErrorInfo)vm).HasErrors);
            if (!this.Bindings.TryGetValue(name, out var binding)) Debugger.Break();
            switch (binding)
            {
                case VmBinding<TModel, TMsg>.OneWay oneWay:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(oneWay));
                case VmBinding<TModel, TMsg>.OneWayLazy oneWayLazy:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(oneWayLazy));
                case VmBinding<TModel, TMsg>.OneWaySeq oneWaySeq:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ObservableCollection<object>>(name,
                        vm => (ObservableCollection<object>)vm.TryGetMember(oneWaySeq));
                case VmBinding<TModel, TMsg>.TwoWay twoWay:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(twoWay), (vm, value) => vm.TrySetMember(value, twoWay));
                case VmBinding<TModel, TMsg>.TwoWayValidate twoWayValidate:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(twoWayValidate), (vm, value) => vm.TrySetMember(value, twoWayValidate));
                case VmBinding<TModel, TMsg>.Cmd cmd:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ICommand>(name, vm => vm.TryGetMember(cmd) as ICommand);
                case VmBinding<TModel, TMsg>.CmdParam cmdParam:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(cmdParam));
                case VmBinding<TModel, TMsg>.SubModel subModel:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ViewModel<object, object>>(name,
                        vm => vm.TryGetMember(subModel) as ViewModel<object, object>);
                case VmBinding<TModel, TMsg>.SubModelSeq subModelSeq:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ObservableCollection<Uno.ViewModel<object, object>>>(name,
                        vm => (ObservableCollection<Uno.ViewModel<object, object>>)vm.TryGetMember(subModelSeq));
                case VmBinding<TModel, TMsg>.SubModelSelectedItem subModelSelectedItem:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ViewModel<object, object>>(name,
                        vm => (ViewModel<object, object>) vm.TryGetMember(subModelSelectedItem));
                case VmBinding<TModel, TMsg>.Cached cached:
                    return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name,
                        vm => vm.TryGetMember(cached), (vm, value) => vm.TrySetMember(value, cached));
                default:
                    return null;
                    //throw new NotSupportedException();
            }
        }

        public ICustomProperty GetCustomProperty(string name) => GetProperty(name);

        public ICustomProperty GetIndexedProperty(string name, Type type) => GetProperty(name);

        public string GetStringRepresentation() => CurrentModel.ToString();

        public Type Type => CurrentModel.GetType();
    }
}

namespace Elmish.Uno
{
    [RequireQualifiedAccess, CompilationMapping(SourceConstructFlags.Module)]
    public static class ViewModel
    {
        public static object DesignInstance<TModel, TMsg>(TModel model, FSharpList<Binding<TModel, TMsg>> bindings)
        {
            var emptyDispatch = FuncConvert.FromAction((TMsg msg) => { });
            return new Elmish.Windows.ViewModel<TModel, TMsg>(model, emptyDispatch, bindings, ElmConfig.Default, "main");
        }

        public static object DesignInstance<T, TModel, TMsg>(TModel model, Program<T, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>> program)
        {
            var emptyDispatch = FuncConvert.FromAction((TMsg msg) => { });
            var mapping = FSharpFunc<TModel, FSharpFunc<TMsg, Unit>>.InvokeFast(ProgramModule.view(program), model, emptyDispatch);
            return DesignInstance(model, mapping);
        }

        public static void StartLoop<TModel, TMsg>(ElmConfig config, FrameworkElement element, Action<Program<Microsoft.FSharp.Core.Unit, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>>> programRun, Program<Unit, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>> program)
        {
            FSharpRef<FSharpOption<ViewModel<TModel, TMsg>>> lastModel = new FSharpRef<FSharpOption<ViewModel<TModel, TMsg>>>(null);
            FSharpFunc<FSharpFunc<TMsg, Unit>, FSharpFunc<TMsg, Unit>> syncDispatch =
              FuncConvert.FromAction(MakeSyncDispatch<TMsg>(element));
            var setSate = FuncConvert.FromAction(MakeSetState(config, element, program, lastModel));
            programRun.Invoke(
                ProgramModule.withSyncDispatch(syncDispatch,
                  ProgramModule.withSetState(setSate, program)));
        }

        public static void StartLoop<T, TModel, TMsg>(ElmConfig config, FrameworkElement element, Action<T, Program<T, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>>> programRun, Program<T, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>> program, T arg)
        {
            FSharpRef<FSharpOption<ViewModel<TModel, TMsg>>> lastModel = new FSharpRef<FSharpOption<ViewModel<TModel, TMsg>>>(null);
            FSharpFunc<FSharpFunc<TMsg, Unit>, FSharpFunc<TMsg, Unit>> syncDispatch =
              FuncConvert.FromAction(MakeSyncDispatch<TMsg>(element));
            var setSate = FuncConvert.FromAction(MakeSetState(config, element, program, lastModel));

            programRun.Invoke(arg,
                ProgramModule.withSyncDispatch(syncDispatch,
                  ProgramModule.withSetState(setSate, program)));
        }


        private static Action<TModel, FSharpFunc<TMsg, Unit>> MakeSetState<TArg, TModel, TMsg>(ElmConfig config, FrameworkElement element, Program<TArg, TModel, TMsg, FSharpList<Binding<TModel, TMsg>>> program, FSharpRef<FSharpOption<ViewModel<TModel, TMsg>>> lastModel)
        {
            void SetState(TModel model, FSharpFunc<TMsg, Unit> dispatch)
            {
                FSharpOption<ViewModel<TModel, TMsg>> contents = lastModel.contents;
                if (contents != null)
                {
                    contents.Value.UpdateModel(model);
                    return;
                }
                var bindedModel = ProgramModule.view(program).Invoke(model);
                var Bindings = bindedModel.Invoke(dispatch);
                var viewModel = new Elmish.Windows.ViewModel<TModel, TMsg>(model, dispatch, Bindings, config, "main");
                element.DataContext = viewModel;
                lastModel.contents = FSharpOption<ViewModel<TModel, TMsg>>.Some(viewModel);
            }
            return SetState;
        }

        private static Action<FSharpFunc<TMsg, Unit>, TMsg> MakeSyncDispatch<TMsg>(FrameworkElement element)
        {
            void UiDispatch(FSharpFunc<TMsg, Unit> innerDispatch, TMsg msg)
            {
                void DoDispatch(TMsg m)
                {
                    Console.WriteLine("Dispatch");
                    innerDispatch.Invoke(m);
                }

                _ = element.Dispatcher.RunAsync(CoreDispatcherPriority.Normal, () => DoDispatch(msg));
            }

            return UiDispatch;
        }
    }
}

And it partially fixed my issue.
Screenshot 6 now works correctly.
But screenshot 7 does not work correctly.
If I press Reset scope on the MainPage number changes, but if I go to the TestPage subviewmodel binds correctly but its properties do not. So that their bindings fail.

xperiandri · 2021-06-29T23:20:36Z

This now does not work at all in WinUI 0.5.7
Branch https://github.com/xperiandri/Elmish.Uno/tree/uno_winui
ICustomProperty methods are never invoked

Upgraded to Reunion 0.8.0
Still does not work at all.

runceel · 2021-06-30T02:44:52Z

@xperiandri
I might the bug of screenshot 7 is not UWP(WinUI) bugs. Because SetState delegate was called with an object instance of iteration 0 even if I pressed Reset scope button on MainPage. Please put a break point to SetState inner method of MakeSetState method on ViewModel class. And then please do the steps for repro.

You will see the following image after clicking Reset scope button and To test page button. iteration 1 is displayed on MainPage, however lastModel variable is iteration **0**.

I was not able to find the root cause of this bug, because I don't have enough knowledge for F#.

xperiandri · 2021-06-30T10:23:23Z

@runceel thanks, I will have a look

xperiandri · 2021-06-30T10:23:26Z

What about WinUI 3 bug? Do I need to post a new issue about that?

runceel · 2021-06-30T11:07:19Z

@xperiandri Sorry, I'm not a contributor of this repository. So, I can't advice for this.

@chiaramooney any suggestion?

The bug is:

ICustomPropertyProvider doesn't work on Windows App SDK(Project Reunion) 0.8.
- The sample code is working on UWP, but that doesn't work on Windows App SDK 0.8.

This is in my understanding. @xperiandri, If you have any additional information, then please add comments.

xperiandri · 2021-06-30T11:13:02Z

Correct. Worked on 0.5.6 or 0.5.5

xperiandri · 2021-07-06T14:31:45Z

@runceel so I debugged the code and even though commands from the next view model are retrieved (when I reset scope, new view model is created and set to DataContext) but old commands from previous view model called.
Even if I call

element.DataContext = null; // if add this, nothing changes
element.DataContext = viewModel;

it makes no effect.

I suppose that is a bug in WinUI binding implementation

xperiandri · 2021-07-06T14:45:47Z

runceel · 2021-07-08T08:17:38Z

@xperiandri
I think it is NOT a bug of the UWP binding engine.
I have added a command property to the model and ViewModel class that is implemented ICustomPropertyProvider interface on addCommand branch on my repository.

https://github.com/runceel/CustomPropertyProviderApp/tree/addCommand

The command worked as well when I replaced DataContext property with a new instance.

Did you implement INotifyPropertyChanged interface correctly on your ViewModel class? Please check my repro project.

xperiandri · 2021-07-08T13:07:36Z

@runceel thanks.
Fixed

internal class ViewModel<TModel, TMsg> : Uno.ViewModel<TModel, TMsg>, ICustomPropertyProvider
{
    private readonly ImmutableDictionary<string, string> bindings;

    public ViewModel(TModel initialModel, FSharpFunc<TMsg, Unit> dispatch, FSharpList<Binding<TModel, TMsg>> bindings, ElmConfig config, string propNameChain) : base(initialModel, dispatch, bindings, config, propNameChain)
    {
        string GetBindingType(Binding<TModel, TMsg> binding)
        {
            //var (info, _) = FSharpValue.GetUnionFields(binding.Data, typeof(BindingData<TModel, TMsg>), FSharpOption<BindingFlags>.Some(BindingFlags.NonPublic));
            return binding.Data.GetType().Name;
        }

        this.bindings = bindings.ToImmutableDictionary(b => b.Name, GetBindingType);
    }

    public override Uno.ViewModel<object, object> Create(object initialModel, FSharpFunc<object, Unit> dispatch, FSharpList<Binding<object, object>> bindings, ElmConfig config, string propNameChain)
        => new ViewModel<object, object>(initialModel, dispatch, bindings, config, propNameChain);

    private ICustomProperty GetProperty(string name)
    {
        if (name == "CurrentModel") return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.CurrentModel);
        if (name == "HasErrors") return new DynamicCustomProperty<ViewModel<TModel, TMsg>, bool>(name, vm => ((INotifyDataErrorInfo)vm).HasErrors);
        if (!bindings.TryGetValue(name, out var bindingType)) Debugger.Break();
        switch (bindingType)
        {
            case nameof(BindingData<TModel, TMsg>.OneWayData):
            case nameof(BindingData<TModel, TMsg>.OneWayLazyData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.OneWaySeqLazyData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ObservableCollection<object>>(name,
                    vm => (ObservableCollection<object>)vm.TryGetMember(vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.TwoWayData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name,
                    vm => vm.TryGetMember(vm.Bindings[name]), (vm, value) => vm.TrySetMember(value, vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.TwoWayValidateData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name,
                    vm => vm.TryGetMember(vm.Bindings[name]), (vm, value) => vm.TrySetMember(value, vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.CmdData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ICommand>(name,
                    vm => vm.TryGetMember(vm.Bindings[name]) as ICommand);
            case nameof(BindingData<TModel, TMsg>.CmdParamData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, object>(name, vm => vm.TryGetMember(vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.SubModelData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ViewModel<object, object>>(name,
                    vm => vm.TryGetMember(vm.Bindings[name]) as ViewModel<object, object>);
            case nameof(BindingData<TModel, TMsg>.SubModelSeqData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ObservableCollection<Uno.ViewModel<object, object>>>(name,
                    vm => (ObservableCollection<Uno.ViewModel<object, object>>)vm.TryGetMember(vm.Bindings[name]));
            case nameof(BindingData<TModel, TMsg>.SubModelSelectedItemData):
                return new DynamicCustomProperty<ViewModel<TModel, TMsg>, ViewModel<object, object>>(name,
                    vm => (ViewModel<object, object>)vm.TryGetMember(vm.Bindings[name]));
            default:
                return null;
                //throw new NotSupportedException();
        }
    }

    public ICustomProperty GetCustomProperty(string name) => GetProperty(name);

    public ICustomProperty GetIndexedProperty(string name, Type type) => GetProperty(name);

    public string GetStringRepresentation() => CurrentModel.ToString();

    public Type Type => CurrentModel.GetType();
}

xperiandri · 2021-07-08T13:09:07Z

The issue was present because I've been getting bindings from the first view model, so that command instance was extracted from old bindings

xperiandri · 2021-07-08T13:26:06Z

You can close the issue

xperiandri · 2021-07-08T14:59:30Z

Created separate issue for WinUI 3

ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 28, 2021

StephenLPeters added team-Framework area-Binding product-winui3 WinUI 3 issues labels Apr 28, 2021

chrisglein added bug Something isn't working needs-author-feedback Asked author to supply more information. and removed needs-triage Issue needs to be triaged by the area owners product-winui3 WinUI 3 issues labels May 17, 2021

ghost added the no-recent-activity label May 25, 2021

ghost removed the no-recent-activity label May 25, 2021

chrisglein added needs-triage Issue needs to be triaged by the area owners and removed needs-author-feedback Asked author to supply more information. labels May 26, 2021

chrisglein closed this as completed Jul 21, 2021

ghost removed the needs-triage Issue needs to be triaged by the area owners label Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swapping view model (same type, new instance) that exposes ICustomPropertyProvider does not trigger Bindings update #4913

Swapping view model (same type, new instance) that exposes ICustomPropertyProvider does not trigger Bindings update #4913

dim-37 commented Apr 28, 2021

ranjeshj commented Apr 28, 2021

xperiandri commented Apr 29, 2021

dim-37 commented Apr 29, 2021

xperiandri commented May 10, 2021

chrisglein commented May 17, 2021

xperiandri commented May 18, 2021

xperiandri commented May 18, 2021 •

edited

Loading

xperiandri commented May 18, 2021

xperiandri commented May 18, 2021

ghost commented May 25, 2021

xperiandri commented May 25, 2021

chiaramooney commented May 26, 2021

xperiandri commented May 26, 2021

xperiandri commented May 31, 2021

xperiandri commented Jun 7, 2021

xperiandri commented Jun 20, 2021

runceel commented Jun 29, 2021 •

edited

Loading

runceel commented Jun 29, 2021 •

edited

Loading

xperiandri commented Jun 29, 2021

xperiandri commented Jun 29, 2021

xperiandri commented Jun 29, 2021

runceel commented Jun 30, 2021 •

edited

Loading

xperiandri commented Jun 30, 2021

xperiandri commented Jun 30, 2021

runceel commented Jun 30, 2021

xperiandri commented Jun 30, 2021

xperiandri commented Jul 6, 2021

xperiandri commented Jul 6, 2021

runceel commented Jul 8, 2021

xperiandri commented Jul 8, 2021 •

edited

Loading

xperiandri commented Jul 8, 2021 •

edited

Loading

xperiandri commented Jul 8, 2021

xperiandri commented Jul 8, 2021

Swapping view model (same type, new instance) that exposes ICustomPropertyProvider does not trigger Bindings update #4913

Swapping view model (same type, new instance) that exposes ICustomPropertyProvider does not trigger Bindings update #4913

Comments

dim-37 commented Apr 28, 2021

ranjeshj commented Apr 28, 2021

xperiandri commented Apr 29, 2021

dim-37 commented Apr 29, 2021

xperiandri commented May 10, 2021

chrisglein commented May 17, 2021

xperiandri commented May 18, 2021

xperiandri commented May 18, 2021 • edited Loading

xperiandri commented May 18, 2021

xperiandri commented May 18, 2021

ghost commented May 25, 2021

xperiandri commented May 25, 2021

chiaramooney commented May 26, 2021

xperiandri commented May 26, 2021

xperiandri commented May 31, 2021

xperiandri commented Jun 7, 2021

xperiandri commented Jun 20, 2021

runceel commented Jun 29, 2021 • edited Loading

runceel commented Jun 29, 2021 • edited Loading

xperiandri commented Jun 29, 2021

xperiandri commented Jun 29, 2021

xperiandri commented Jun 29, 2021

runceel commented Jun 30, 2021 • edited Loading

xperiandri commented Jun 30, 2021

xperiandri commented Jun 30, 2021

runceel commented Jun 30, 2021

xperiandri commented Jun 30, 2021

xperiandri commented Jul 6, 2021

xperiandri commented Jul 6, 2021

runceel commented Jul 8, 2021

xperiandri commented Jul 8, 2021 • edited Loading

xperiandri commented Jul 8, 2021 • edited Loading

xperiandri commented Jul 8, 2021

xperiandri commented Jul 8, 2021

xperiandri commented May 18, 2021 •

edited

Loading

runceel commented Jun 29, 2021 •

edited

Loading

runceel commented Jun 29, 2021 •

edited

Loading

runceel commented Jun 30, 2021 •

edited

Loading

xperiandri commented Jul 8, 2021 •

edited

Loading

xperiandri commented Jul 8, 2021 •

edited

Loading