TextBox PlaceholderText is no longer centered correctly in v1.6.0

[Balkoth]

Describe the bug

In WindowsAppSDK 1.5 <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240802000" /> it looks correct like this:

In v1.6 <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240829007" /> it suddenly looks like this:

So whatever has changed it messes with the positioning of the PlaceholderText.

Steps to reproduce the bug

<Window
  x:Class="TextBoxTest.MainWindow"
  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
  xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
  xmlns:local="using:TextBoxTest"
  xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
  mc:Ignorable="d">

  <StackPanel
    HorizontalAlignment="Center"
    VerticalAlignment="Center"
    Orientation="Horizontal">
    <TextBox PlaceholderText="Search..." />
    <Button x:Name="myButton" Click="myButton_Click">Click Me</Button>
  </StackPanel>
</Window>

Expected behavior

No response

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.6.0: 1.6.240829007

Windows version

Windows 10 (21H2): Build 19044

Additional context

No response

[Balkoth]

Not fixed.

[Balkoth]

Does anyone even care? This breaks the whole styling and makes the app look ugly now.

[Trix07]

I just got around to updating our application from 1.5.7 to 1.6.1 and immediately noticed the same issue. The CheckBox control also seems to be affected, as it displays the content at the top instead of centering it vertically.

Have you found any workarounds for this issue?

[Balkoth]

Unfortunately not. Are you too on Windows 10?

[Trix07]

Yeah, I'm still on Windows 10. I tested it on a Windows 11 machine, and it works fine there, so it seems to be an issue only affecting Windows 10 machines.

[Balkoth]

Thought so...

[Temetra]

I'm having the same problem with TextBlocks, also on Windows 10.

I'm currently working around it by changing LineHeight and LineStackingStrategy:

<Style x:Key="xBaseTextBlockStyle" TargetType="TextBlock" BasedOn="{StaticResource BaseTextBlockStyle}">
    <Setter Property="LineHeight" Value="19.5" />
    <Setter Property="LineStackingStrategy" Value="BlockLineHeight" />
</Style>

It's a hassle though. TextBox, CheckBox etc are harder because the TextBlock is nested. The entire template will need to be duplicated.

You can find the original source in .nuget\packages\microsoft.windowsappsdk\1.6.240923002\lib\uap10.0\Microsoft.UI\Themes\generic.xaml

[Balkoth]

I guess we can agree that changing and duplicating whole templates, to fix a bug that 1.6.0 introduced is a no-go.

[eaproton]

WindowsAppSDK 1.7.241114004-experimental1 also seems to have the same issue. So it is still not fixed in 1.7.