remove option to do use Overwrite conflict resolution modes

Author: KinoriSR

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Commands/FileSystem/ImportJob/FileSystemImportJobCreateCommand.cs

@@ -30,7 +30,15 @@ public sealed class FileSystemImportJobCreateCommand(ILogger<FileSystemImportJob
 
     public override string Title => CommandTitle;
 
-    public override ToolMetadata Metadata => new() { Destructive = false, ReadOnly = false };
+    public override ToolMetadata Metadata => new()
+    {
+        Destructive = false,
+        Idempotent = true,
+        OpenWorld = true,
+        ReadOnly = false,
+        LocalRequired = false,
+        Secret = false
+    };
 
     protected override void RegisterOptions(Command command)
     {
@@ -56,7 +64,22 @@ protected override FileSystemImportJobCreateOptions BindOptions(ParseResult pars
         {
             options.ImportPrefixes = prefixes.ToList();
         }
-        options.ConflictResolutionMode = parseResult.GetValueOrDefault(_conflictResolutionModeOption) ?? "Skip";
+        var conflictMode = parseResult.GetValueOrDefault(_conflictResolutionModeOption);
+        if (string.IsNullOrWhiteSpace(conflictMode))
+        {
+            conflictMode = "Skip"; // default
+        }
+        else
+        {
+            if (!string.Equals(conflictMode, "Skip", StringComparison.OrdinalIgnoreCase) &&
+                !string.Equals(conflictMode, "Fail", StringComparison.OrdinalIgnoreCase))
+            {
+                throw new ArgumentException("Azure MCP Server's Managed Lustre tooling does not support the specified conflict resolution mode. This is because the mode doesn't exist or the tool does not support potentially destructive import conflict resolution modes (overwrite variants).", nameof(_conflictResolutionModeOption));
+            }
+            // Normalize casing
+            conflictMode = char.ToUpperInvariant(conflictMode[0]) + conflictMode.Substring(1).ToLowerInvariant();
+        }
+        options.ConflictResolutionMode = conflictMode;
         options.MaximumErrors = parseResult.GetValueOrDefault(_maximumErrorsOption) ?? -1;
         options.AdminStatus = "Active"; // Hard-coded since service no longer accepts parameter
         options.Name = parseResult.GetValueOrDefault(_nameOption);
@@ -80,7 +103,7 @@ public override async Task<CommandResponse> ExecuteAsync(CommandContext context,
                 options.FileSystem!,
                 options.Name,
                 options.ImportPrefixes,
-                options.ConflictResolutionMode,
+                options.ConflictResolutionMode!,
                 options.MaximumErrors,
                 options.Tenant,
                 options.RetryPolicy);

tools/Azure.Mcp.Tools.AzureManagedLustre/src/Options/AzureManagedLustreOptionDefinitions.cs

@@ -67,7 +67,7 @@ public static class AzureManagedLustreOptionDefinitions
         $"--{conflictResolutionMode}"
     )
     {
-        Description = "How to handle conflicts during import. Allowed values: OverwriteIfDirty, OverwriteAlways, Fail, Skip. Default: Skip.",
+        Description = "How to handle conflicts during import. Allowed values: Fail, Skip. Default: Skip.",
         Required = false
     };
 

tools/Azure.Mcp.Tools.AzureManagedLustre/tests/Azure.Mcp.Tools.AzureManagedLustre.UnitTests/FileSystem/ImportJob/FileSystemImportJobCreateCommandTests.cs

@@ -244,4 +244,19 @@ public async Task ExecuteAsync_ServiceThrows_GenericException_Returns500()
         Assert.True(response.Status >= 500);
         Assert.Contains("boom", response.Message, StringComparison.OrdinalIgnoreCase);
     }
+
+    [Fact]
+    public async Task ExecuteAsync_InvalidConflictResolutionMode_ThrowsArgumentException()
+    {
+        var args = _commandDefinition.Parse([
+            "--subscription", _subscription,
+            "--resource-group", _resourceGroup,
+            "--file-system", _fileSystem,
+            "--conflict-resolution-mode", "OverwriteAlways"
+        ]);
+
+        var ex = await Assert.ThrowsAsync<ArgumentException>(async () => await _command.ExecuteAsync(_context, args));
+        Assert.Contains("does not support", ex.Message, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("overwrite", ex.Message, StringComparison.OrdinalIgnoreCase);
+    }
 }