Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly sending textDocument/didSave notifications #288

Closed
prabirshrestha opened this issue Aug 27, 2017 · 1 comment
Closed

correctly sending textDocument/didSave notifications #288

prabirshrestha opened this issue Aug 27, 2017 · 1 comment
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@prabirshrestha
Copy link
Member

prabirshrestha commented Aug 27, 2017

//cc @rcjsuen

The confusion started from rcjsuen/dockerfile-language-server#165.

I'm implementing the LSP server for vim at https://github.com/prabirshrestha/vim-lsp. And I would like to know when should it send textDocument/didSave changes to the client.

Here are the possibilities. (I would like to support both v2 and v3 porotocols).Is the table correct?

serverCapabilities Send textDocument/didSave notification includeText
{}
{ 'textDocumentSync: 0/1/2 } ✔️
{ 'textDocumentSync: {} }
{ 'textDocumentSync: {save: {} } } ✔️
{ 'textDocumentSync: { save: { includeText: true } } } ✔️ ✔️
{ 'textDocumentSync: { save: { includeText: false} } } ✔️
@dbaeumer
Copy link
Member

dbaeumer commented Oct 3, 2017

@prabirshrestha your table is correct.

Please note that v1 didn't have a didSave notification. But you are not targeting this.

@dbaeumer dbaeumer closed this as completed Oct 3, 2017
@dbaeumer dbaeumer added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Oct 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants