Task: remove kiota interop tight coupling #6096
Conversation
| - name: run tests(linux) | ||
| if: runner.os == 'Linux' | ||
| run: xvfb-run -a npm run test-with-coverage | ||
| run: xvfb-run -a npm run test:coverage |
There was a problem hiding this comment.
leaving a note so we can better understand what's the situation with coverage.
There was a problem hiding this comment.
I got to go through it. The changes introduced by this PR: #6171 removed the filter that keeps the vscode folder outside of the dotnet sonarqube checks. Without this filter the vscode extension will definitely fail the checks because the workflow uses dotnet to test.
Some more configuration work will be required to bring in the report from the sonarqube checks that are already placed inside the build-vscode-extension.yml similar to the comment that comes in when the dotnet side is checked. Currently what we have is the production of the code coverage and a connection to the sonarqube host and not the handover back to the PR.
This work is however outside the scope of this PR and may need its own item and prioritisation
| @@ -0,0 +1,257 @@ | |||
| export enum KiotaGenerationLanguage { | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
There was a problem hiding this comment.
shouldn't this file be in the lib section as well?
…ttps://github.com/microsoft/kiota into task/extension/remove-kiota-interop-tight-coupling
|
Overview
Closes #6084
Notes
Introduces a new module to decouple the Kiota Interop code from the VS Code extension. The most significant changes involve the addition of unit tests, and refactoring of command implementations of the interop module by moving all of them away into the module.
Changes
Application folder>{AppData}\Microsoft Kiota\.kiotabinregardless of OS. Moving the.kiotabinfolder outside of the vscode extension environment enabling sharing with different apps on the same devicevscodewere removed from the kiota interop codeconnectToKiotahave moved to the module library as independent functions exported via theindex.tsfileruntime.jsonfile with the intent to ship it together with the module so that it can carry the binary information (in theruntimeDependenciesproperty) and thekiotaVersionnumber.package.jsonfile in the vscode extension no-longer carries theruntimeDependenciesandkiotaVersionproperties.