genpolicy: Introduce UpdateInterfaceRequest rules in genpolicy-settings + tests #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
2 times, most recently
from
2b796a4 to
7e00311
Compare
Camelron
commented
Mar 4, 2025
Redent0r
reviewed
Mar 5, 2025
Redent0r
reviewed
Mar 5, 2025
|
small genpolicy |
Redent0r
reviewed
Mar 5, 2025
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
2 times, most recently
from
9c782e9 to
6172c64
Compare
sprt
reviewed
Mar 5, 2025
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
3 times, most recently
from
2d5a839 to
fe06a2b
Compare
Redent0r
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
from
fe06a2b to
caf6b58
Compare
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
from
caf6b58 to
dc85a8c
Compare
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
from
dc85a8c to
05a1609
Compare
danmihai1
requested changes
Mar 5, 2025
| "IPAddresses": [ | ||
| { | ||
| "family": 0, | ||
| "address": "10.244.0.14", |
There was a problem hiding this comment.
Our main goal here is to guard Guest's loopback interface, if needed. I don't think it's worth trying to hard-code non-loopback IP addresses.
Author
There was a problem hiding this comment.
Okay, I removed the policy checks for IPAddresses
Introduce rules for UpdateInterfaceRequest and genpolicy tests for them. Signed-off-by: Cameron Baird <[email protected]>
Make corresponding updates to sample pod yamls for UpdateInterfaceRequest rules Signed-off-by: Cameron Baird <[email protected]>
Camelron
force-pushed
the
cameronbaird/updateinterfacerequest-hardening
branch
from
05a1609 to
2a9c385
Compare
manuelh-dev
reviewed
Mar 7, 2025
| metadata: | ||
| name: dummy | ||
| spec: | ||
| runtimeClassName: kata-cc-isolation |
There was a problem hiding this comment.
why are we doing kata-cc-isolation here?
Author
|
Dead branch, duplicate of this change: #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce rules for UpdateInterfaceRequest and genpolicy tests for them.