Saulparedes/validate namespace env var #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmihai1
reviewed
Jan 15, 2025
Redent0r
force-pushed
the
saulparedes/validate_namespace_env_var
branch
4 times, most recently
from
be99469 to
8c83019
Compare
…space Use $(sandbox-namespace) wildcard in case none is specified in yaml. If wildcard is present, compare input against annotation value. Fixes regression introduced in #273 where samples that use metadata.namespace env var were no longer working. Signed-off-by: Saul Paredes <[email protected]>
Update samples Signed-off-by: Saul Paredes <[email protected]>
Redent0r
force-pushed
the
saulparedes/validate_namespace_env_var
branch
from
8c83019 to
a3f20ba
Compare
danmihai1
approved these changes
Jan 17, 2025
manuelh-dev
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Use $(sandbox-namespace) wildcard in case none is specified in yaml. If wildcard is present, compare
input against annotation value.
Fixes regression introduced in #273
where samples that use metadata.namespace env var were no longer working.
Test Methodology
test run https://dev.azure.com/mariner-org/mariner/_build/results?buildId=713340&view=ms.vss-test-web.build-test-results-tab [passing]