Skip to content

samples: update ubuntu sample to use 18.04 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

samples: update ubuntu sample to use 18.04 #220

merged 1 commit into from
Aug 20, 2024

Conversation

@Redent0r
Copy link

@Redent0r Redent0r commented Aug 20, 2024 •
edited
Loading

This is a more stable tag. Previous tag got updated yesterday and requires to update the annotation.

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Previous tag got updated yesterday and caused 3 test failures: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=624769&view=ms.vss-test-web.build-test-results-tab

New tag hasn't been updated since 06/02/2023 and looks more stable. This new tag will allow us to keep testing ubuntu, without the need to frequently update the annotation

Test Methodology

test run: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=625055&view=results

@Redent0r
samples: update ubuntu sample to use 18.04
32ac40e 
This is a more stable tag. Previous tag got updated yesterday and
requires to update the annotation.

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Aug 20, 2024
@Redent0r Redent0r marked this pull request as ready for review August 20, 2024 19:30
@Redent0r Redent0r requested review from a team as code owners August 20, 2024 19:30
@Redent0r Redent0r merged commit f17f994 into msft-main Aug 20, 2024
@Redent0r Redent0r deleted the saulparedes/update_ubuntu_sample branch August 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

Assignees

No one assigned

Labels

upstream/not-needed PRs that will not be upstreamed (e.g. internal)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Redent0r @danmihai1