genpolicy: add support for runAsUser #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add policy support for SecurityContext and PodSecurityContext runAsUser. Also, remove outdated UID rule workaround. Fixes: kata-containers#8879 Signed-off-by: Dan Mihai <[email protected]>
Update samples after adding support for runAsUser. Signed-off-by: Dan Mihai <[email protected]>
sprt
reviewed
Jan 23, 2024
| process.User.UID = uid.try_into().unwrap(); | ||
| } | ||
| if let Some(allow) = context.allowPrivilegeEscalation { | ||
| process.NoNewPrivileges = !allow |
There was a problem hiding this comment.
Does this compile with the missing semicolon? I'm guessing Rust considers this as a void expression?
Author
There was a problem hiding this comment.
It does - even the make check below passed.
I would rather change this in a future PR, to avoid re-testing. I agree it looks odd, and it wasn't intentional. I forgot it in there because this code used to look a bit differently:
process.NoNewPrivileges = if let Some(allow) = context.allowPrivilegeEscalation {
!allow
} else {
// something else that we don't need here
};
sprt
approved these changes
Jan 23, 2024
Redent0r
added
upstream/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add policy support for SecurityContext and PodSecurityContext runAsUser.
Also, remove outdated UID rule workaround.