Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-sync script shouldn't overwrite ongoing fixup work #68

Closed
dagood opened this issue Apr 26, 2021 · 0 comments · Fixed by microsoft/go-infra#175
Closed

Auto-sync script shouldn't overwrite ongoing fixup work #68

dagood opened this issue Apr 26, 2021 · 0 comments · Fixed by microsoft/go-infra#175

Comments

@dagood
Copy link
Member

dagood commented Apr 26, 2021

Right now, the auto-sync script force pushes to the PR branch, then tries to create a PR, then (if PR creation fails) tries to find the PR so it can re-enable auto-merge.

It should either do nothing if the PR exists, or detect whether or not it makes sense to push the new commit to the old PR.
This was referenced Sep 3, 2021
Closed
Merged
@dagood dagood mentioned this issue Sep 16, 2021
Merged
@dagood dagood mentioned this issue Oct 29, 2021
Closed
@dagood dagood mentioned this issue Mar 25, 2022
Merged
@dagood dagood mentioned this issue May 2, 2022
Open
This was referenced Sep 27, 2024
Merged
Merged
@dagood dagood mentioned this issue Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
@dagood's Go infra tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync: skip a push that would overwrite another's change microsoft/go-infra
1 participant
@dagood