Misc BDN additions (#683)

* Misc BDN additions

* nit

* nit

Author: badrishc

benchmark/BDN.benchmark/Resp/RespAofStress.cs

@@ -0,0 +1,103 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+using System.Runtime.CompilerServices;
+using BenchmarkDotNet.Attributes;
+using Embedded.perftest;
+using Garnet.server;
+
+namespace BDN.benchmark.Resp
+{
+    [MemoryDiagnoser]
+    public unsafe class RespAofStress
+    {
+        EmbeddedRespServer server;
+        RespServerSession session;
+        const int batchSize = 128;
+
+        static ReadOnlySpan<byte> SET => "*3\r\n$3\r\nSET\r\n$1\r\na\r\n$1\r\na\r\n"u8;
+        byte[] setRequestBuffer;
+        byte* setRequestBufferPointer;
+
+        static ReadOnlySpan<byte> INCR => "*2\r\n$4\r\nINCR\r\n$1\r\ni\r\n"u8;
+        byte[] incrRequestBuffer;
+        byte* incrRequestBufferPointer;
+
+        static ReadOnlySpan<byte> LPUSHPOP => "*3\r\n$5\r\nLPUSH\r\n$1\r\nd\r\n$1\r\ne\r\n*2\r\n$4\r\nLPOP\r\n$1\r\nd\r\n"u8;
+        byte[] lPushPopRequestBuffer;
+        byte* lPushPopRequestBufferPointer;
+
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            var opt = new GarnetServerOptions
+            {
+                QuietMode = true,
+                EnableAOF = true,
+                UseAofNullDevice = true,
+                MainMemoryReplication = true,
+                CommitFrequencyMs = -1,
+                AofPageSize = "128m",
+                AofMemorySize = "256m",
+            };
+            server = new EmbeddedRespServer(opt);
+
+            session = server.GetRespSession();
+
+            setRequestBuffer = GC.AllocateArray<byte>(SET.Length * batchSize, pinned: true);
+            setRequestBufferPointer = (byte*)Unsafe.AsPointer(ref setRequestBuffer[0]);
+            for (int i = 0; i < batchSize; i++)
+                SET.CopyTo(new Span<byte>(setRequestBuffer).Slice(i * SET.Length));
+
+            _ = session.TryConsumeMessages(setRequestBufferPointer, setRequestBuffer.Length);
+
+            incrRequestBuffer = GC.AllocateArray<byte>(INCR.Length * batchSize, pinned: true);
+            incrRequestBufferPointer = (byte*)Unsafe.AsPointer(ref incrRequestBuffer[0]);
+            for (int i = 0; i < batchSize; i++)
+                INCR.CopyTo(new Span<byte>(incrRequestBuffer).Slice(i * INCR.Length));
+
+            _ = session.TryConsumeMessages(incrRequestBufferPointer, incrRequestBuffer.Length);
+
+            lPushPopRequestBuffer = GC.AllocateArray<byte>(LPUSHPOP.Length * batchSize, pinned: true);
+            lPushPopRequestBufferPointer = (byte*)Unsafe.AsPointer(ref lPushPopRequestBuffer[0]);
+            for (int i = 0; i < batchSize; i++)
+                LPUSHPOP.CopyTo(new Span<byte>(lPushPopRequestBuffer).Slice(i * LPUSHPOP.Length));
+
+            // Pre-populate list with a single element to avoid repeatedly emptying it during the benchmark
+            SlowConsumeMessage("*3\r\n$5\r\nLPUSH\r\n$1\r\nd\r\n$1\r\nf\r\n"u8);
+        }
+
+        [GlobalCleanup]
+        public void GlobalCleanup()
+        {
+            session.Dispose();
+            server.Dispose();
+        }
+
+        [Benchmark]
+        public void Set()
+        {
+            _ = session.TryConsumeMessages(setRequestBufferPointer, setRequestBuffer.Length);
+        }
+
+        [Benchmark]
+        public void Increment()
+        {
+            _ = session.TryConsumeMessages(incrRequestBufferPointer, incrRequestBuffer.Length);
+        }
+
+        [Benchmark]
+        public void LPushPop()
+        {
+            _ = session.TryConsumeMessages(lPushPopRequestBufferPointer, lPushPopRequestBuffer.Length);
+        }
+
+        private void SlowConsumeMessage(ReadOnlySpan<byte> message)
+        {
+            var buffer = GC.AllocateArray<byte>(message.Length, pinned: true);
+            var bufferPointer = (byte*)Unsafe.AsPointer(ref buffer[0]);
+            message.CopyTo(new Span<byte>(buffer));
+            _ = session.TryConsumeMessages(bufferPointer, buffer.Length);
+        }
+    }
+}

benchmark/BDN.benchmark/Resp/RespParseStress.cs

@@ -35,6 +35,10 @@ public unsafe class RespParseStress
         byte[] getRequestBuffer;
         byte* getRequestBufferPointer;
 
+        static ReadOnlySpan<byte> INCR => "*2\r\n$4\r\nINCR\r\n$1\r\ni\r\n"u8;
+        byte[] incrRequestBuffer;
+        byte* incrRequestBufferPointer;
+
         static ReadOnlySpan<byte> ZADDREM => "*4\r\n$4\r\nZADD\r\n$1\r\nc\r\n$1\r\n1\r\n$1\r\nc\r\n*3\r\n$4\r\nZREM\r\n$1\r\nc\r\n$1\r\nc\r\n"u8;
         byte[] zAddRemRequestBuffer;
         byte* zAddRemRequestBufferPointer;
@@ -62,8 +66,6 @@ public void GlobalSetup()
             {
                 QuietMode = true,
                 AuthSettings = authSettings,
-                MetricsSamplingFrequency = 5,
-                LatencyMonitor = true,
             };
             server = new EmbeddedRespServer(opt);
 
@@ -94,6 +96,11 @@ public void GlobalSetup()
             for (int i = 0; i < batchSize; i++)
                 GET.CopyTo(new Span<byte>(getRequestBuffer).Slice(i * GET.Length));
 
+            incrRequestBuffer = GC.AllocateArray<byte>(INCR.Length * batchSize, pinned: true);
+            incrRequestBufferPointer = (byte*)Unsafe.AsPointer(ref incrRequestBuffer[0]);
+            for (int i = 0; i < batchSize; i++)
+                INCR.CopyTo(new Span<byte>(incrRequestBuffer).Slice(i * INCR.Length));
+
             zAddRemRequestBuffer = GC.AllocateArray<byte>(ZADDREM.Length * batchSize, pinned: true);
             zAddRemRequestBufferPointer = (byte*)Unsafe.AsPointer(ref zAddRemRequestBuffer[0]);
             for (int i = 0; i < batchSize; i++)
@@ -118,7 +125,7 @@ public void GlobalSetup()
             SlowConsumeMessage("*4\r\n$4\r\nZADD\r\n$1\r\nc\r\n$1\r\n1\r\n$1\r\nd\r\n"u8);
 
             // Pre-populate list with a single element to avoid repeatedly emptying it during the benchmark
-            SlowConsumeMessage("*3\r\n$4\r\nLPUSH\r\n$1\r\nd\r\n$1\r\nf\r\n"u8);
+            SlowConsumeMessage("*3\r\n$5\r\nLPUSH\r\n$1\r\nd\r\n$1\r\nf\r\n"u8);
 
             // Pre-populate set with a single element to avoid repeatedly emptying it during the benchmark
             SlowConsumeMessage("*3\r\n$4\r\nSADD\r\n$1\r\ne\r\n$1\r\nb\r\n"u8);
@@ -166,6 +173,12 @@ public void Get()
             _ = session.TryConsumeMessages(getRequestBufferPointer, getRequestBuffer.Length);
         }
 
+        [Benchmark]
+        public void Increment()
+        {
+            _ = session.TryConsumeMessages(incrRequestBufferPointer, incrRequestBuffer.Length);
+        }
+
         [Benchmark]
         public void ZAddRem()
         {