From b95edd40da51ed349e17a3c78a244b758547aa93 Mon Sep 17 00:00:00 2001 From: Kevin Coughlin Date: Thu, 21 Feb 2019 10:38:02 -0800 Subject: [PATCH 1/2] Modify mergeAriaAttributeValues to space delimit output by default --- packages/utilities/src/aria.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/utilities/src/aria.ts b/packages/utilities/src/aria.ts index 2dc852d098fe6e..38328b770870b7 100644 --- a/packages/utilities/src/aria.ts +++ b/packages/utilities/src/aria.ts @@ -2,11 +2,9 @@ * ARIA helper to concatenate attributes, returning undefined if all attributes * are undefined. (Empty strings are not a valid ARIA attribute value.) * - * NOTE: This function will NOT insert whitespace between provided attributes. - * * @param ariaAttributes - ARIA attributes to merge */ export function mergeAriaAttributeValues(...ariaAttributes: (string | undefined)[]): string | undefined { - const mergedAttribute = ariaAttributes.filter((arg: string | undefined) => arg !== undefined && arg !== null).join(''); + const mergedAttribute = ariaAttributes.filter((arg: string | undefined) => arg !== undefined && arg !== null).join(' '); return mergedAttribute === '' ? undefined : mergedAttribute; } From b8b83265f1a0e55f4e6b20d67eb425327fe54211 Mon Sep 17 00:00:00 2001 From: Kevin Coughlin Date: Thu, 21 Feb 2019 10:39:05 -0800 Subject: [PATCH 2/2] Add change file --- .../keco-fix-merge-aria-attrs_2019-02-21-18-39.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@uifabric/utilities/keco-fix-merge-aria-attrs_2019-02-21-18-39.json diff --git a/common/changes/@uifabric/utilities/keco-fix-merge-aria-attrs_2019-02-21-18-39.json b/common/changes/@uifabric/utilities/keco-fix-merge-aria-attrs_2019-02-21-18-39.json new file mode 100644 index 00000000000000..2ed67ee46a4eb5 --- /dev/null +++ b/common/changes/@uifabric/utilities/keco-fix-merge-aria-attrs_2019-02-21-18-39.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@uifabric/utilities", + "comment": "Modify mergeAriaAttributeValues to return space delimited string of values", + "type": "patch" + } + ], + "packageName": "@uifabric/utilities", + "email": "keco@microsoft.com" +} \ No newline at end of file