From c4eed27615843125a5b886e37b0574d17231fa65 Mon Sep 17 00:00:00 2001 From: "huaxi@microsoft.com" Date: Tue, 4 Dec 2018 14:21:12 -0800 Subject: [PATCH 1/4] make spellCheck defaults to false in BasePicker --- .../office-ui-fabric-react/src/components/pickers/BasePicker.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx index f6fe25f01ac7b..c874d0371d845 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx +++ b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx @@ -224,6 +224,7 @@ export class BasePicker> extends BaseComponent< aria-owns={suggestionsAvailable || undefined} aria-autocomplete={'both'} onInputChange={this.props.onInputChange} + spellCheck={false} /> )} From 3a18057ed9ac4bf3c4a72af2f95880b8e29d367b Mon Sep 17 00:00:00 2001 From: "huaxi@microsoft.com" Date: Tue, 4 Dec 2018 14:21:56 -0800 Subject: [PATCH 2/4] rush change --- ...uaxi-no-spellcheck-in-picker_2018-12-04-22-21.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json diff --git a/common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json b/common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json new file mode 100644 index 0000000000000..6b33e01900f30 --- /dev/null +++ b/common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "spellCheck defaults to false in BasePicker", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "huaxi@microsoft.com" +} \ No newline at end of file From 47d2d0fd2a67feb4a9ae52fd9e8816e206295897 Mon Sep 17 00:00:00 2001 From: "huaxi@microsoft.com" Date: Wed, 5 Dec 2018 14:41:57 -0800 Subject: [PATCH 3/4] updated snapshots --- .../__snapshots__/PeoplePicker.Types.Example.tsx.shot | 1 + .../components/__snapshots__/TagPicker.Basic.Example.tsx.shot | 2 ++ .../components/pickers/__snapshots__/BasePicker.test.tsx.snap | 3 +++ 3 files changed, 6 insertions(+) diff --git a/packages/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot b/packages/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot index 76799c9eeca4f..21aae816de51b 100644 --- a/packages/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot +++ b/packages/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot @@ -53,6 +53,7 @@ exports[`Component Examples renders PeoplePicker.Types.Example.tsx correctly 1`] onInput={[Function]} onKeyDown={[Function]} role="combobox" + spellCheck={false} value="" /> diff --git a/packages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot b/packages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot index 08cac0d5d53fb..56df2d075760f 100644 --- a/packages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot +++ b/packages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot @@ -208,6 +208,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] = onInput={[Function]} onKeyDown={[Function]} role="combobox" + spellCheck={false} value="" /> @@ -268,6 +269,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] = onInput={[Function]} onKeyDown={[Function]} role="combobox" + spellCheck={false} value="" /> diff --git a/packages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap b/packages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap index 55033f6e51fdd..8d85fe4db8b40 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap @@ -51,6 +51,7 @@ exports[`Pickers BasePicker renders BasePicker correctly 1`] = ` onInput={[Function]} onKeyDown={[Function]} role="combobox" + spellCheck={false} value="" /> @@ -112,6 +113,7 @@ exports[`Pickers BasePicker renders BasePicker with inputProps supply classnames onKeyDown={[Function]} placeholder="Bitte einen Benutzer angeben..." role="combobox" + spellCheck={false} value="" /> @@ -171,6 +173,7 @@ exports[`Pickers TagPicker renders TagPicker correctly 1`] = ` onInput={[Function]} onKeyDown={[Function]} role="combobox" + spellCheck={false} value="" /> From deb43001833c44540f02ffec34db721756959dd8 Mon Sep 17 00:00:00 2001 From: "huaxi@microsoft.com" Date: Wed, 5 Dec 2018 17:00:09 -0800 Subject: [PATCH 4/4] allowed inputProps to overwrite spellCheck --- .../src/components/pickers/BasePicker.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx index c874d0371d845..d598270ac25b3 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx +++ b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx @@ -205,6 +205,7 @@ export class BasePicker> extends BaseComponent< {this.canAddItems() && ( > extends BaseComponent< aria-owns={suggestionsAvailable || undefined} aria-autocomplete={'both'} onInputChange={this.props.onInputChange} - spellCheck={false} /> )}