diff --git a/common/changes/office-ui-fabric-react/fix-globals_2018-06-06-22-18.json b/common/changes/office-ui-fabric-react/fix-globals_2018-06-06-22-18.json new file mode 100644 index 0000000000000..547d6854a70a0 --- /dev/null +++ b/common/changes/office-ui-fabric-react/fix-globals_2018-06-06-22-18.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Add global name to scss files using global selector to tag in sideEffects.", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "lynam.emily@gmail.com" +} \ No newline at end of file diff --git a/packages/office-ui-fabric-react/package.json b/packages/office-ui-fabric-react/package.json index bcbfa915c5068..59aaae62d14e3 100644 --- a/packages/office-ui-fabric-react/package.json +++ b/packages/office-ui-fabric-react/package.json @@ -4,7 +4,11 @@ "description": "Reusable React components for building experiences for Office 365.", "main": "lib-commonjs/index.js", "module": "lib/index.js", - "sideEffects": false, + "sideEffects": [ + "*.global.js", + "*Examples.js", + "*Example.js" + ], "typings": "lib/index.d.ts", "repository": { "type": "git", diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.scss b/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.global.scss similarity index 100% rename from packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.scss rename to packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.global.scss diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.tsx b/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.tsx index 69121ec217bcb..7d61c7abcd997 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.tsx +++ b/packages/office-ui-fabric-react/src/components/HoverCard/HoverCardPage.tsx @@ -6,7 +6,7 @@ import { IDemoPageProps } from '../../demo/components/DemoPage.types'; import { HoverCardTargetExample } from './examples/HoverCard.Target.Example'; import { HoverCardStatus } from './HoverCard.checklist'; -import './HoverCardPage.scss'; +import './HoverCardPage.global.scss'; const HoverCardBasicExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/HoverCard/examples/HoverCard.Basic.Example.tsx') as string; const HoverCardTargetExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/HoverCard/examples/HoverCard.Target.Example.tsx') as string; diff --git a/packages/office-ui-fabric-react/src/components/Image/ImagePage.scss b/packages/office-ui-fabric-react/src/components/Image/ImagePage.global.scss similarity index 100% rename from packages/office-ui-fabric-react/src/components/Image/ImagePage.scss rename to packages/office-ui-fabric-react/src/components/Image/ImagePage.global.scss diff --git a/packages/office-ui-fabric-react/src/components/Image/ImagePage.tsx b/packages/office-ui-fabric-react/src/components/Image/ImagePage.tsx index 7a3f8977146a1..7c116607d4924 100644 --- a/packages/office-ui-fabric-react/src/components/Image/ImagePage.tsx +++ b/packages/office-ui-fabric-react/src/components/Image/ImagePage.tsx @@ -1,5 +1,5 @@ import * as React from 'react'; -import './ImagePage.scss'; +import './ImagePage.global.scss'; import { DemoPage } from '../../demo/components/DemoPage'; import { IDemoPageProps } from '../../demo/components/DemoPage.types'; import { ImageDefaultExample } from './examples/Image.Default.Example'; diff --git a/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.scss b/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.global.scss similarity index 100% rename from packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.scss rename to packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.global.scss diff --git a/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.tsx b/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.tsx index d18b6eb9d5027..b26231b96900d 100644 --- a/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.tsx +++ b/packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.tsx @@ -1,5 +1,5 @@ import * as React from 'react'; -import './ThemeGeneratorPage.scss'; +import './ThemeGeneratorPage.global.scss'; import { BaseComponent } from 'office-ui-fabric-react/lib/Utilities'; import { loadTheme } from 'office-ui-fabric-react/lib/Styling'; diff --git a/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.scss b/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.global.scss similarity index 100% rename from packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.scss rename to packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.global.scss diff --git a/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.tsx b/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.tsx index 10189b0798a1f..7384a7e6e23a6 100644 --- a/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.tsx +++ b/packages/office-ui-fabric-react/src/components/Tooltip/TooltipPage.tsx @@ -8,7 +8,7 @@ import { TooltipInteractiveExample } from './examples/Tooltip.Interactive.Exampl import { TooltipOverflowExample } from './examples/Tooltip.Overflow.Example'; import { TooltipStatus } from './Tooltip.checklist'; -import './TooltipPage.scss'; +import './TooltipPage.global.scss'; const TooltipBasicExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/Tooltip/examples/Tooltip.Basic.Example.tsx') as string; const TooltipCustomExampleCode = require('!raw-loader!office-ui-fabric-react/src/components/Tooltip/examples/Tooltip.Custom.Example.tsx') as string;