From bc158090d49ea7aa6c1873f2e66f7ed6c76303a5 Mon Sep 17 00:00:00 2001 From: David Zearing Date: Tue, 5 Jun 2018 23:48:49 -0700 Subject: [PATCH 1/2] Updating tslint to default deprecation to on (and adding a bunch of exclusions to remove in separate checkins.) --- apps/fabric-website/tslint.json | 1 + apps/todo-app/tslint.json | 1 + packages/example-app-base/tslint.json | 1 + packages/experiments/tslint.json | 4 +++- packages/office-ui-fabric-react-tslint/tslint.json | 1 + packages/office-ui-fabric-react/tslint.json | 1 + packages/styling/tslint.json | 1 + packages/utilities/tslint.json | 1 + 8 files changed, 10 insertions(+), 1 deletion(-) diff --git a/apps/fabric-website/tslint.json b/apps/fabric-website/tslint.json index 3fffcbc1bbd300..e900a89ef0c1bf 100644 --- a/apps/fabric-website/tslint.json +++ b/apps/fabric-website/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "no-any": false, "no-inferrable-types": false, "typedef": [false], diff --git a/apps/todo-app/tslint.json b/apps/todo-app/tslint.json index fcd7c0cd0ed790..d023300e877979 100644 --- a/apps/todo-app/tslint.json +++ b/apps/todo-app/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "no-any": false, "typedef": [false], "prefer-const": false diff --git a/packages/example-app-base/tslint.json b/packages/example-app-base/tslint.json index eb7053a9990ab9..009fd22f9fc96c 100644 --- a/packages/example-app-base/tslint.json +++ b/packages/example-app-base/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "prefer-const": false } } diff --git a/packages/experiments/tslint.json b/packages/experiments/tslint.json index 40ab7504688566..22a7b31df2cae4 100644 --- a/packages/experiments/tslint.json +++ b/packages/experiments/tslint.json @@ -1,4 +1,6 @@ { "extends": ["office-ui-fabric-react-tslint"], - "rules": {} + "rules": { + "deprecation": false + } } diff --git a/packages/office-ui-fabric-react-tslint/tslint.json b/packages/office-ui-fabric-react-tslint/tslint.json index a23755a0452896..26e3d4635c8735 100644 --- a/packages/office-ui-fabric-react-tslint/tslint.json +++ b/packages/office-ui-fabric-react-tslint/tslint.json @@ -1,6 +1,7 @@ { "extends": ["tslint-react"], "rules": { + "deprecation": true, "function-name": [ true, { diff --git a/packages/office-ui-fabric-react/tslint.json b/packages/office-ui-fabric-react/tslint.json index fdc90c8e61ac4e..e46dedb733298b 100644 --- a/packages/office-ui-fabric-react/tslint.json +++ b/packages/office-ui-fabric-react/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "jsx-ban-props": false, "max-line-length": [false, 140], "no-any": false, diff --git a/packages/styling/tslint.json b/packages/styling/tslint.json index eb7053a9990ab9..009fd22f9fc96c 100644 --- a/packages/styling/tslint.json +++ b/packages/styling/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "prefer-const": false } } diff --git a/packages/utilities/tslint.json b/packages/utilities/tslint.json index eb7053a9990ab9..009fd22f9fc96c 100644 --- a/packages/utilities/tslint.json +++ b/packages/utilities/tslint.json @@ -1,6 +1,7 @@ { "extends": ["office-ui-fabric-react-tslint"], "rules": { + "deprecation": false, "prefer-const": false } } From 00865534f5d58b40e273563537f70fd01372fb7b Mon Sep 17 00:00:00 2001 From: David Zearing Date: Tue, 5 Jun 2018 23:49:20 -0700 Subject: [PATCH 2/2] Adding change files to make the change file check happy. --- .../deprecation_2018-06-06-06-49.json | 11 +++++++++++ .../experiments/deprecation_2018-06-06-06-49.json | 11 +++++++++++ .../fabric-website/deprecation_2018-06-06-06-49.json | 11 +++++++++++ .../styling/deprecation_2018-06-06-06-49.json | 11 +++++++++++ .../utilities/deprecation_2018-06-06-06-49.json | 11 +++++++++++ .../deprecation_2018-06-06-06-49.json | 11 +++++++++++ 6 files changed, 66 insertions(+) create mode 100644 common/changes/@uifabric/example-app-base/deprecation_2018-06-06-06-49.json create mode 100644 common/changes/@uifabric/experiments/deprecation_2018-06-06-06-49.json create mode 100644 common/changes/@uifabric/fabric-website/deprecation_2018-06-06-06-49.json create mode 100644 common/changes/@uifabric/styling/deprecation_2018-06-06-06-49.json create mode 100644 common/changes/@uifabric/utilities/deprecation_2018-06-06-06-49.json create mode 100644 common/changes/office-ui-fabric-react/deprecation_2018-06-06-06-49.json diff --git a/common/changes/@uifabric/example-app-base/deprecation_2018-06-06-06-49.json b/common/changes/@uifabric/example-app-base/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..cde5b3e29d95ce --- /dev/null +++ b/common/changes/@uifabric/example-app-base/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "@uifabric/example-app-base", + "type": "none" + } + ], + "packageName": "@uifabric/example-app-base", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/@uifabric/experiments/deprecation_2018-06-06-06-49.json b/common/changes/@uifabric/experiments/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..2098be827ee862 --- /dev/null +++ b/common/changes/@uifabric/experiments/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "@uifabric/experiments", + "type": "none" + } + ], + "packageName": "@uifabric/experiments", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/@uifabric/fabric-website/deprecation_2018-06-06-06-49.json b/common/changes/@uifabric/fabric-website/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..119379ee8c0a8c --- /dev/null +++ b/common/changes/@uifabric/fabric-website/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "@uifabric/fabric-website", + "type": "none" + } + ], + "packageName": "@uifabric/fabric-website", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/@uifabric/styling/deprecation_2018-06-06-06-49.json b/common/changes/@uifabric/styling/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..f6d55bf7f71ba1 --- /dev/null +++ b/common/changes/@uifabric/styling/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "@uifabric/styling", + "type": "none" + } + ], + "packageName": "@uifabric/styling", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/@uifabric/utilities/deprecation_2018-06-06-06-49.json b/common/changes/@uifabric/utilities/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..dd57bd067a20d2 --- /dev/null +++ b/common/changes/@uifabric/utilities/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "@uifabric/utilities", + "type": "none" + } + ], + "packageName": "@uifabric/utilities", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/office-ui-fabric-react/deprecation_2018-06-06-06-49.json b/common/changes/office-ui-fabric-react/deprecation_2018-06-06-06-49.json new file mode 100644 index 00000000000000..bdac204cd2e2e6 --- /dev/null +++ b/common/changes/office-ui-fabric-react/deprecation_2018-06-06-06-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "", + "packageName": "office-ui-fabric-react", + "type": "none" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file