From 8d0eac02c08c190467831e948c8a8663d73991a1 Mon Sep 17 00:00:00 2001 From: Philip Kuo Date: Wed, 23 May 2018 17:44:31 -0700 Subject: [PATCH 1/3] fix error colors --- .../office-ui-fabric-react/src/common/_themeOverrides.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/office-ui-fabric-react/src/common/_themeOverrides.scss b/packages/office-ui-fabric-react/src/common/_themeOverrides.scss index b2751d5578eeb..986b6504de289 100644 --- a/packages/office-ui-fabric-react/src/common/_themeOverrides.scss +++ b/packages/office-ui-fabric-react/src/common/_themeOverrides.scss @@ -49,8 +49,8 @@ $ms-color-greenDark: "[theme:greenDark, default: #004b1c]"; $ms-color-green: "[theme:green, default: #107c10]"; $ms-color-greenLight: "[theme:greenLight, default: #bad80a]"; $ms-color-error: "[theme:error, default: #a80000]"; -$ms-color-errorText: "[theme:errorText, default: #333333]"; -$ms-color-errorBackground: "[theme:errorBackground, default: #fde7e9]"; +$ms-color-errorText: "[theme:errorTextOld, default: #333333]"; +$ms-color-errorBackground: "[theme:errorBackgroundOld, default: #fde7e9]"; $ms-color-success: "[theme:success, default: #107c10]"; $ms-color-successText: "[theme:successText, default: #333333]"; $ms-color-successBackground: "[theme:successBackground, default: #dff6dd]"; From 849cf5fdc1f886c458393f7cd7675f4417d23a8b Mon Sep 17 00:00:00 2001 From: Philip Kuo Date: Wed, 23 May 2018 18:29:06 -0700 Subject: [PATCH 2/3] better fix --- .../office-ui-fabric-react/src/common/_themeOverrides.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/office-ui-fabric-react/src/common/_themeOverrides.scss b/packages/office-ui-fabric-react/src/common/_themeOverrides.scss index 986b6504de289..de5228436a57b 100644 --- a/packages/office-ui-fabric-react/src/common/_themeOverrides.scss +++ b/packages/office-ui-fabric-react/src/common/_themeOverrides.scss @@ -49,8 +49,8 @@ $ms-color-greenDark: "[theme:greenDark, default: #004b1c]"; $ms-color-green: "[theme:green, default: #107c10]"; $ms-color-greenLight: "[theme:greenLight, default: #bad80a]"; $ms-color-error: "[theme:error, default: #a80000]"; -$ms-color-errorText: "[theme:errorTextOld, default: #333333]"; -$ms-color-errorBackground: "[theme:errorBackgroundOld, default: #fde7e9]"; +$ms-color-errorText: "[theme:warningText, default: #333333]"; +$ms-color-errorBackground: "[theme:errorBackground, default: rgba(232,17,35,.2)]"; $ms-color-success: "[theme:success, default: #107c10]"; $ms-color-successText: "[theme:successText, default: #333333]"; $ms-color-successBackground: "[theme:successBackground, default: #dff6dd]"; From 9a89a122c5836f6d6d7025748c6d2911cdd42f3d Mon Sep 17 00:00:00 2001 From: Philip Kuo Date: Thu, 24 May 2018 15:16:57 -0700 Subject: [PATCH 3/3] changefile --- .../phkuo-fixErrorColors_2018-05-24-22-16.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/phkuo-fixErrorColors_2018-05-24-22-16.json diff --git a/common/changes/office-ui-fabric-react/phkuo-fixErrorColors_2018-05-24-22-16.json b/common/changes/office-ui-fabric-react/phkuo-fixErrorColors_2018-05-24-22-16.json new file mode 100644 index 0000000000000..caedaa348968d --- /dev/null +++ b/common/changes/office-ui-fabric-react/phkuo-fixErrorColors_2018-05-24-22-16.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "fix old error color SASS variables so they work when themed", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "phkuo@microsoft.com" +} \ No newline at end of file