From 107c4f224d6176d873b113d5ce31cb7924110ddb Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 7 May 2018 12:19:10 -0700 Subject: [PATCH 1/9] margin 0 reset style for buttons in safari --- .../src/components/Button/BaseButton.styles.ts | 3 ++- .../src/components/Button/SplitButton/SplitButton.styles.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts b/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts index 734dc7b6e51f20..a53867dcda88bf 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts @@ -58,7 +58,8 @@ export const getStyles = memoizeFunction(( cursor: 'pointer', verticalAlign: 'top', padding: '0 16px', - borderRadius: 0 + borderRadius: 0, + margin: 0 } ], diff --git a/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts b/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts index c596d1ee0fde60..79da8e844e7379 100644 --- a/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts +++ b/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts @@ -43,6 +43,7 @@ export const getStyles = memoizeFunction(( cursor: 'pointer', verticalAlign: 'top', width: 32, + margin: 0, marginLeft: -1 }, From 402e56d25af8566bc339fb04819a000b6e30e081 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 7 May 2018 12:20:08 -0700 Subject: [PATCH 2/9] rush change --- .../safari-button-reset-3691_2018-05-07-19-19.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json diff --git a/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json b/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json new file mode 100644 index 00000000000000..3fab71bd8bada7 --- /dev/null +++ b/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Set 'margin 0' reset style for buttons in Safari", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "v-brgarl@microsoft.com" +} \ No newline at end of file From 123622c72233ee13a1151daa757a077b56547ac6 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 7 May 2018 12:21:05 -0700 Subject: [PATCH 3/9] update snapshots --- .../__snapshots__/Breadcrumb.test.tsx.snap | 8 ++ .../Button/__snapshots__/Button.test.tsx.snap | 24 ++++ .../__snapshots__/ComboBox.test.tsx.snap | 8 ++ .../__snapshots__/Facepile.test.tsx.snap | 4 + .../Nav/__snapshots__/Nav.test.tsx.snap | 4 + .../Pivot/__snapshots__/Pivot.test.tsx.snap | 8 ++ .../__snapshots__/SpinButton.test.tsx.snap | 8 ++ .../SwatchColorPicker.test.tsx.snap | 48 +++++++ .../__snapshots__/Suggestions.test.tsx.snap | 120 ++++++++++++++++++ 9 files changed, 232 insertions(+) diff --git a/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap index 4c19fa80cd7922..da21ad1bc1608c 100644 --- a/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap @@ -443,6 +443,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 2 1`] = ` font-size: 16px; font-weight: 400; height: 100%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; @@ -1162,6 +1166,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 4 1`] = ` font-size: 16px; font-weight: 400; height: 100%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap index 82efc10b8e6542..522e05ef7cce3c 100644 --- a/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap @@ -24,6 +24,10 @@ exports[`Button renders ActionButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -139,6 +143,10 @@ exports[`Button renders CommandBarButton correctly 1`] = ` font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif; font-size: 14px; font-weight: 400; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0; @@ -309,6 +317,10 @@ exports[`Button renders CompoundButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: auto; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; max-width: 280px; min-height: 72px; outline: transparent; @@ -450,6 +462,10 @@ exports[`Button renders DefaultButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; min-width: 80px; outline: transparent; padding-bottom: 0; @@ -560,6 +576,10 @@ exports[`Button renders IconButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -677,6 +697,10 @@ exports[`Button renders a DefaultButton with a keytip correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; min-width: 80px; outline: transparent; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap b/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap index 887217b51b81a4..4eb6919ab91426 100644 --- a/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap @@ -180,6 +180,10 @@ exports[`ComboBox Renders ComboBox correctly 1`] = ` font-weight: 400; height: 32px; line-height: 30px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -467,6 +471,10 @@ exports[`ComboBox renders a ComboBox with a Keytip correctly 1`] = ` font-weight: 400; height: 32px; line-height: 30px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; diff --git a/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap index a0fe083dbe4566..f6425cf5065232 100644 --- a/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap @@ -193,6 +193,10 @@ exports[`Facepile renders Facepile correctly 1`] = ` font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif; font-size: 14px; font-weight: 400; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 16px; diff --git a/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap index 66c5323cb47ddc..2dd8685039f72d 100644 --- a/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap @@ -99,6 +99,10 @@ exports[`Nav renders Nav correctly 1`] = ` font-weight: 400; height: 36px; line-height: 36px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap index b0217b47b18177..451256e29b3c80 100644 --- a/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap @@ -43,6 +43,10 @@ exports[`Pivot renders Pivot correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -149,6 +153,10 @@ exports[`Pivot renders Pivot correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; diff --git a/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap b/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap index e947da8dff65cc..f18d6af4c6774f 100644 --- a/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap @@ -173,6 +173,10 @@ exports[`SpinButton renders SpinButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 50%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: none; padding-bottom: 0; padding-left: 0; @@ -296,6 +300,10 @@ exports[`SpinButton renders SpinButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 50%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: none; padding-bottom: 0; padding-left: 0; diff --git a/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap b/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap index 6d0d031f772a0e..0771aea7d07572 100644 --- a/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap @@ -75,6 +75,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -272,6 +276,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -469,6 +477,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -666,6 +678,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -867,6 +883,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1064,6 +1084,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1261,6 +1285,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1458,6 +1486,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1659,6 +1691,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1856,6 +1892,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -2053,6 +2093,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -2250,6 +2294,10 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; diff --git a/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap b/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap index 8693ae63381035..657a3d8378035e 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap @@ -42,6 +42,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -148,6 +152,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -254,6 +262,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -360,6 +372,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -466,6 +482,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -572,6 +592,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -678,6 +702,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -784,6 +812,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -890,6 +922,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -996,6 +1032,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1102,6 +1142,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1208,6 +1252,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1314,6 +1362,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1420,6 +1472,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1526,6 +1582,10 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1646,6 +1706,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1752,6 +1816,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1858,6 +1926,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1964,6 +2036,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2070,6 +2146,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2176,6 +2256,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2282,6 +2366,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2388,6 +2476,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2494,6 +2586,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2600,6 +2696,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2706,6 +2806,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2812,6 +2916,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2918,6 +3026,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -3024,6 +3136,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -3130,6 +3246,10 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; From f03e022fb2d4f9b2fed86e670eee29d891fa89b4 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 7 May 2018 13:18:13 -0700 Subject: [PATCH 4/9] experiments snapshot updates --- .../CommandBar/__snapshots__/CommandBar.test.tsx.snap | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap b/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap index a719afd259c46d..bac12231af9690 100644 --- a/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap +++ b/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap @@ -76,6 +76,10 @@ exports[`CommandBar renders commands correctly 1`] = ` font-size: 14px; font-weight: 400; height: 100%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0; @@ -188,6 +192,10 @@ exports[`CommandBar renders commands correctly 1`] = ` font-size: 14px; font-weight: 400; height: 100%; + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0; From b20088f748dc365a5fba587eb2cd63f6009f7efa Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 7 May 2018 14:12:49 -0700 Subject: [PATCH 5/9] rush change in experiments --- .../safari-button-reset-3691_2018-05-07-21-12.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json diff --git a/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json b/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json new file mode 100644 index 00000000000000..bf63ff19e772f3 --- /dev/null +++ b/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@uifabric/experiments", + "comment": "Set 'margin 0' reset style for buttons in Safari and updated snapshots in experiments", + "type": "patch" + } + ], + "packageName": "@uifabric/experiments", + "email": "v-brgarl@microsoft.com" +} \ No newline at end of file From 9bc167b76089a1594231641335bf79c369406e09 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 21 May 2018 10:43:44 -0700 Subject: [PATCH 6/9] Move margin 0 to Fabric component as reset targeting button --- .../src/components/Button/BaseButton.styles.ts | 3 +-- .../src/components/Button/SplitButton/SplitButton.styles.ts | 1 - .../src/components/Fabric/Fabric.styles.ts | 3 ++- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts b/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts index a53867dcda88bf..734dc7b6e51f20 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts @@ -58,8 +58,7 @@ export const getStyles = memoizeFunction(( cursor: 'pointer', verticalAlign: 'top', padding: '0 16px', - borderRadius: 0, - margin: 0 + borderRadius: 0 } ], diff --git a/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts b/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts index 79da8e844e7379..c596d1ee0fde60 100644 --- a/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts +++ b/packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts @@ -43,7 +43,6 @@ export const getStyles = memoizeFunction(( cursor: 'pointer', verticalAlign: 'top', width: 32, - margin: 0, marginLeft: -1 }, diff --git a/packages/office-ui-fabric-react/src/components/Fabric/Fabric.styles.ts b/packages/office-ui-fabric-react/src/components/Fabric/Fabric.styles.ts index 6bb242e30bdbc0..15c707894f1e37 100644 --- a/packages/office-ui-fabric-react/src/components/Fabric/Fabric.styles.ts +++ b/packages/office-ui-fabric-react/src/components/Fabric/Fabric.styles.ts @@ -32,7 +32,8 @@ export const getStyles = (props: IFabricStyleProps): IFabricStyles => { '& input': inheritFont, '& textarea': inheritFont, ':global(button)': { - overflow: 'visible' + overflow: 'visible', + margin: 0 } } }, From 1b0e373f17a392eeb53884baa90c5ebfe417d87b Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 21 May 2018 10:46:09 -0700 Subject: [PATCH 7/9] update snapshots --- .../__snapshots__/Breadcrumb.test.tsx.snap | 8 -- .../Button/__snapshots__/Button.test.tsx.snap | 24 ---- .../__snapshots__/ComboBox.test.tsx.snap | 8 -- .../Fabric/__snapshots__/Fabric.test.tsx.snap | 4 + .../__snapshots__/Facepile.test.tsx.snap | 4 - .../Nav/__snapshots__/Nav.test.tsx.snap | 4 - .../Pivot/__snapshots__/Pivot.test.tsx.snap | 8 -- .../__snapshots__/SpinButton.test.tsx.snap | 8 -- .../SwatchColorPicker.test.tsx.snap | 48 ------- .../__snapshots__/Suggestions.test.tsx.snap | 120 ------------------ 10 files changed, 4 insertions(+), 232 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap index da21ad1bc1608c..4c19fa80cd7922 100644 --- a/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap @@ -443,10 +443,6 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 2 1`] = ` font-size: 16px; font-weight: 400; height: 100%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; @@ -1166,10 +1162,6 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 4 1`] = ` font-size: 16px; font-weight: 400; height: 100%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap index 522e05ef7cce3c..82efc10b8e6542 100644 --- a/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap @@ -24,10 +24,6 @@ exports[`Button renders ActionButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -143,10 +139,6 @@ exports[`Button renders CommandBarButton correctly 1`] = ` font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif; font-size: 14px; font-weight: 400; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0; @@ -317,10 +309,6 @@ exports[`Button renders CompoundButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: auto; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; max-width: 280px; min-height: 72px; outline: transparent; @@ -462,10 +450,6 @@ exports[`Button renders DefaultButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; min-width: 80px; outline: transparent; padding-bottom: 0; @@ -576,10 +560,6 @@ exports[`Button renders IconButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -697,10 +677,6 @@ exports[`Button renders a DefaultButton with a keytip correctly 1`] = ` font-size: 14px; font-weight: 400; height: 32px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; min-width: 80px; outline: transparent; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap b/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap index 4eb6919ab91426..887217b51b81a4 100644 --- a/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap @@ -180,10 +180,6 @@ exports[`ComboBox Renders ComboBox correctly 1`] = ` font-weight: 400; height: 32px; line-height: 30px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -471,10 +467,6 @@ exports[`ComboBox renders a ComboBox with a Keytip correctly 1`] = ` font-weight: 400; height: 32px; line-height: 30px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; diff --git a/packages/office-ui-fabric-react/src/components/Fabric/__snapshots__/Fabric.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Fabric/__snapshots__/Fabric.test.tsx.snap index 12987076b58890..c1e2ebcfb8bca4 100644 --- a/packages/office-ui-fabric-react/src/components/Fabric/__snapshots__/Fabric.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Fabric/__snapshots__/Fabric.test.tsx.snap @@ -22,6 +22,10 @@ exports[`Fabric renders correctly 1`] = ` font-family: inherit; } button { + margin-bottom: 0px; + margin-left: 0px; + margin-right: 0px; + margin-top: 0px; overflow: visible; } > diff --git a/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap index f6425cf5065232..a0fe083dbe4566 100644 --- a/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap @@ -193,10 +193,6 @@ exports[`Facepile renders Facepile correctly 1`] = ` font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif; font-size: 14px; font-weight: 400; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 16px; diff --git a/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap index 2dd8685039f72d..66c5323cb47ddc 100644 --- a/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap @@ -99,10 +99,6 @@ exports[`Nav renders Nav correctly 1`] = ` font-weight: 400; height: 36px; line-height: 36px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: hidden; padding-bottom: 0; diff --git a/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap index 451256e29b3c80..b0217b47b18177 100644 --- a/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap @@ -43,10 +43,6 @@ exports[`Pivot renders Pivot correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -153,10 +149,6 @@ exports[`Pivot renders Pivot correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; diff --git a/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap b/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap index f18d6af4c6774f..e947da8dff65cc 100644 --- a/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap @@ -173,10 +173,6 @@ exports[`SpinButton renders SpinButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 50%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: none; padding-bottom: 0; padding-left: 0; @@ -300,10 +296,6 @@ exports[`SpinButton renders SpinButton correctly 1`] = ` font-size: 14px; font-weight: 400; height: 50%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: none; padding-bottom: 0; padding-left: 0; diff --git a/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap b/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap index 0771aea7d07572..6d0d031f772a0e 100644 --- a/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/SwatchColorPicker/__snapshots__/SwatchColorPicker.test.tsx.snap @@ -75,10 +75,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -276,10 +272,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -477,10 +469,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -678,10 +666,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -883,10 +867,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1084,10 +1064,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1285,10 +1261,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1486,10 +1458,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1691,10 +1659,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -1892,10 +1856,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -2093,10 +2053,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; @@ -2294,10 +2250,6 @@ exports[`SwatchColorPicker renders SwatchColorPicker correctly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; overflow: visible; padding-bottom: 0px; diff --git a/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap b/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap index 657a3d8378035e..8693ae63381035 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/pickers/Suggestions/__snapshots__/Suggestions.test.tsx.snap @@ -42,10 +42,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -152,10 +148,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -262,10 +254,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -372,10 +360,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -482,10 +466,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -592,10 +572,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -702,10 +678,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -812,10 +784,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -922,10 +890,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1032,10 +996,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1142,10 +1102,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1252,10 +1208,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1362,10 +1314,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1472,10 +1420,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1582,10 +1526,6 @@ exports[`Suggestions renders a list properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1706,10 +1646,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1816,10 +1752,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -1926,10 +1858,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2036,10 +1964,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2146,10 +2070,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2256,10 +2176,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2366,10 +2282,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2476,10 +2388,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2586,10 +2494,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2696,10 +2600,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2806,10 +2706,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -2916,10 +2812,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -3026,10 +2918,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -3136,10 +3024,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; @@ -3246,10 +3130,6 @@ exports[`Suggestions scrolls to selected index properly 1`] = ` font-size: 14px; font-weight: 400; height: 40px; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; outline: transparent; padding-bottom: 0; padding-left: 4px; From 18175654db89423d3c7196ea73d5d4d7d0d80b3e Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 21 May 2018 10:47:38 -0700 Subject: [PATCH 8/9] rush change changes --- .../experiments/safari-button-reset-3691_2018-05-07-21-12.json | 2 +- .../safari-button-reset-3691_2018-05-07-19-19.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json b/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json index bf63ff19e772f3..e9aea4b7458de5 100644 --- a/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json +++ b/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json @@ -2,7 +2,7 @@ "changes": [ { "packageName": "@uifabric/experiments", - "comment": "Set 'margin 0' reset style for buttons in Safari and updated snapshots in experiments", + "comment": "Set 'margin 0' reset style for buttons in Safari in Fabric component", "type": "patch" } ], diff --git a/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json b/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json index 3fab71bd8bada7..960bb08c1132c2 100644 --- a/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json +++ b/common/changes/office-ui-fabric-react/safari-button-reset-3691_2018-05-07-19-19.json @@ -2,7 +2,7 @@ "changes": [ { "packageName": "office-ui-fabric-react", - "comment": "Set 'margin 0' reset style for buttons in Safari", + "comment": "Set 'margin 0' reset style for buttons in Safari in Fabric component", "type": "patch" } ], From a1d2a53ce0d619326acc613dd98ffa111b9efbd5 Mon Sep 17 00:00:00 2001 From: Brian Garland Date: Mon, 21 May 2018 11:04:27 -0700 Subject: [PATCH 9/9] cleanup experiments --- .../safari-button-reset-3691_2018-05-07-21-12.json | 11 ----------- .../CommandBar/__snapshots__/CommandBar.test.tsx.snap | 8 -------- 2 files changed, 19 deletions(-) delete mode 100644 common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json diff --git a/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json b/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json deleted file mode 100644 index e9aea4b7458de5..00000000000000 --- a/common/changes/@uifabric/experiments/safari-button-reset-3691_2018-05-07-21-12.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@uifabric/experiments", - "comment": "Set 'margin 0' reset style for buttons in Safari in Fabric component", - "type": "patch" - } - ], - "packageName": "@uifabric/experiments", - "email": "v-brgarl@microsoft.com" -} \ No newline at end of file diff --git a/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap b/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap index bac12231af9690..a719afd259c46d 100644 --- a/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap +++ b/packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap @@ -76,10 +76,6 @@ exports[`CommandBar renders commands correctly 1`] = ` font-size: 14px; font-weight: 400; height: 100%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0; @@ -192,10 +188,6 @@ exports[`CommandBar renders commands correctly 1`] = ` font-size: 14px; font-weight: 400; height: 100%; - margin-bottom: 0px; - margin-left: 0px; - margin-right: 0px; - margin-top: 0px; min-width: 40px; outline: transparent; padding-bottom: 0;