diff --git a/common/changes/office-ui-fabric-react/rebeba-contextual-menu-focus_2018-05-07-21-16.json b/common/changes/office-ui-fabric-react/rebeba-contextual-menu-focus_2018-05-07-21-16.json new file mode 100644 index 00000000000000..8165a281a87228 --- /dev/null +++ b/common/changes/office-ui-fabric-react/rebeba-contextual-menu-focus_2018-05-07-21-16.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Fixes issue where focus isn't displayed correctly on the contextual mneu", + "type": "minor" + } + ], + "packageName": "office-ui-fabric-react", + "email": "rebeba@microsoft.com" +} \ No newline at end of file diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx index b76784d5f153eb..2363f38db1e71f 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx @@ -430,6 +430,7 @@ export class BaseButton extends BaseComponent { + private _openMenu = (shouldFocusOnContainer?: boolean): void => { if (this.props.menuProps) { - const menuProps = this.props.menuProps; + const menuProps = {...this.props.menuProps, shouldFocusOnContainer: shouldFocusOnContainer }; if (this.props.persistMenu) { menuProps.hidden = false; } @@ -457,16 +458,16 @@ export class BaseButton extends BaseComponent { + private _onToggleMenu = (shouldFocusOnContainer: boolean): void => { if (this._splitButtonContainer.current) { this._splitButtonContainer.current.focus(); } const currentMenuProps = this.state.menuProps; if (this.props.persistMenu) { - currentMenuProps && currentMenuProps.hidden ? this._openMenu() : this._dismissMenu(); + currentMenuProps && currentMenuProps.hidden ? this._openMenu(shouldFocusOnContainer) : this._dismissMenu(); } else { - currentMenuProps ? this._dismissMenu() : this._openMenu(); + currentMenuProps ? this._dismissMenu() : this._openMenu(shouldFocusOnContainer); } } @@ -628,14 +629,13 @@ export class BaseButton extends BaseComponent