From 8f9e8a1eac2b83b959b49d5bd1d43e0726d26ee4 Mon Sep 17 00:00:00 2001 From: "REDMOND\\naethell" Date: Fri, 30 Mar 2018 16:05:28 -0700 Subject: [PATCH 1/2] dropdown role is listbox --- .../src/components/Dropdown/Dropdown.tsx | 2 +- .../components/Dropdown/__snapshots__/Dropdown.test.tsx.snap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx b/packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx index 3471f5a131d015..92c05c2aeec073 100644 --- a/packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx +++ b/packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx @@ -191,7 +191,7 @@ export class Dropdown extends BaseComponent 0 ? styles.titleIsError : null)) } aria-atomic={ true } - role='textbox' + role='listbox' aria-readonly='true' > { // If option is selected render title, otherwise render the placeholder text diff --git a/packages/office-ui-fabric-react/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap index 219f16707a7dd2..1a8fccb238b0dc 100644 --- a/packages/office-ui-fabric-react/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap @@ -28,7 +28,7 @@ exports[`Dropdown multi-select Renders multiselect Dropdown correctly 1`] = ` aria-readonly="true" className="ms-Dropdown-title ms-Dropdown-titleIsPlaceHolder" id="Dropdown94-option" - role="textbox" + role="listbox" /> Date: Fri, 30 Mar 2018 16:06:26 -0700 Subject: [PATCH 2/2] change file --- .../dropdownsNotEditable_2018-03-30-23-06.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/dropdownsNotEditable_2018-03-30-23-06.json diff --git a/common/changes/office-ui-fabric-react/dropdownsNotEditable_2018-03-30-23-06.json b/common/changes/office-ui-fabric-react/dropdownsNotEditable_2018-03-30-23-06.json new file mode 100644 index 00000000000000..6f5074aa80d75a --- /dev/null +++ b/common/changes/office-ui-fabric-react/dropdownsNotEditable_2018-03-30-23-06.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Dropdown: aria role is `listbox` instead of `textbox`", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "naethell@microsoft.com" +} \ No newline at end of file