From 17e0ddad6ec97f02d73fb971f0f63942e28ca690 Mon Sep 17 00:00:00 2001 From: Mykhailo Bratukha Date: Fri, 16 Mar 2018 09:58:51 +0100 Subject: [PATCH 1/3] [BasePicker] suggestions should not be shown when input does not exist --- .../src/components/pickers/BasePicker.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx index 9351ba8ac67693..025ab23d342e72 100644 --- a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx +++ b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx @@ -230,7 +230,7 @@ export class BasePicker> extends BaseComponent< protected renderSuggestions(): JSX.Element | null { const TypedSuggestion = this.SuggestionOfProperType; - return this.state.suggestionsVisible ? ( + return this.state.suggestionsVisible && this.input ? ( Date: Fri, 16 Mar 2018 10:03:51 +0100 Subject: [PATCH 2/3] added change file --- .../master_2018-03-16-09-03.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json diff --git a/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json b/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json new file mode 100644 index 00000000000000..94827e44a0d3aa --- /dev/null +++ b/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "suggestions should not be shown in BasePicker when input does not exist", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "bratukha.m@gmail.com" +} \ No newline at end of file From 8532ddad225ec4c3ff7c265fc2f97d77d862918d Mon Sep 17 00:00:00 2001 From: David Zearing Date: Fri, 16 Mar 2018 17:22:36 -0700 Subject: [PATCH 3/3] Update master_2018-03-16-09-03.json --- .../office-ui-fabric-react/master_2018-03-16-09-03.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json b/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json index 94827e44a0d3aa..f6e458d841e12e 100644 --- a/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json +++ b/common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json @@ -2,10 +2,10 @@ "changes": [ { "packageName": "office-ui-fabric-react", - "comment": "suggestions should not be shown in BasePicker when input does not exist", + "comment": "BasePicker: suggestions should not be shown in BasePicker when input does not exist.", "type": "patch" } ], "packageName": "office-ui-fabric-react", "email": "bratukha.m@gmail.com" -} \ No newline at end of file +}