diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 6d26005559c42..15fd7b83b20cd 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,4 +1,6 @@ -FROM mcr.microsoft.com/devcontainers/typescript-node:1-16-bookworm +ARG VARIANT=18-bookworm +# https://github.com/devcontainers/images/tree/main/src/typescript-node +FROM mcr.microsoft.com/devcontainers/typescript-node:1-${VARIANT} # Cypress linux pre-requisites https://docs.cypress.io/guides/getting-started/installing-cypress#Linux-Prerequisites RUN apt-get update && apt-get -y install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb diff --git a/.devcontainer/README.md b/.devcontainer/README.md index 6e7fb0b5f6ce3..270534163d38c 100644 --- a/.devcontainer/README.md +++ b/.devcontainer/README.md @@ -4,7 +4,7 @@ This configuration is based on the base Node container provided by VSCode, it sh > For more information on how to use/create `development containers` follow the [VSCode Documentation](https://code.visualstudio.com/docs/remote/create-dev-container) -> See here for more information on the base container https://github.com/microsoft/vscode-dev-containers/tree/v0.222.0/containers/javascript-node/.devcontainer/base.Dockerfile +> See here for more information on the base container https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.Dockerfile ## Cypress tests diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 568c30791a8ab..c4432253ef93a 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,7 +1,10 @@ { "name": "Node.js", "build": { - "dockerfile": "Dockerfile" + "dockerfile": "Dockerfile", + "args": { + "VARIANT": "18-bookworm" + } }, "features": { "ghcr.io/devcontainers/features/github-cli:1": {} diff --git a/lage.config.js b/lage.config.js index 8ddb1dc7fdd27..bbcc8737d89c2 100644 --- a/lage.config.js +++ b/lage.config.js @@ -27,6 +27,7 @@ module.exports = { 'change/**', 'rfcs/**', 'README.md', + '*.md', '.vscode/**', '.github/*.yml', '.github/*.json', @@ -35,6 +36,7 @@ module.exports = { '.github/MAINTAINERS', '.github/ISSUE_TEMPLATE/**', '.github/policies/**', + '.devcontainer/**', ], // All of these options are sent to `backfill`: https://github.com/microsoft/backfill/blob/master/README.md